public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	pbs-devel@lists.proxmox.com
Subject: Re: applied: [PATCH proxmox-backup] sync: pull: use LogLineSender in d SyncSourceReader
Date: Mon, 27 Apr 2026 08:37:08 +0200	[thread overview]
Message-ID: <c1e17cb3-ebfe-4e8f-a690-3ecae14fe24a@proxmox.com> (raw)
In-Reply-To: <c9330d09-6874-4260-8563-e1d355c62c3e@proxmox.com>

On 4/26/26 11:38 PM, Thomas Lamprecht wrote:
> Am 24.04.26 um 15:35 schrieb Dominik Csapak:
>> otherwise some log messages are not rendered with the correct prefix
>> when using multiple worker threads.
>>
>> For example:
>>
>> Snapshot ct/122/2026-04-24T12:56:17Z: got backup log file client.log.blob
>>
>> vs
>>
>> [ct/122]: Snapshot ct/122/2026-04-24T13:00:02Z: got backup log file client.log.blob
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> there may be other places where we don't use the LogLineSender here,
>> but could not find any on first glance.
>>
> I know you were a bit earlier, but I chose Chris variant as the rest
> of his fixes of his series was a bit more crucial [0], might be still
> great if one of you could cross-check to ensure nothing was missed.
> 
> Marking this still as applied here because if effectively should be
> addressed, and thus mail filters used mark it as obsolete. Should I have
> missed something here then it would needs a new submission that was
> rebased on master anyway
> 
> [0]: https://lore.proxmox.com/pbs-devel/20260425140927.928214-3-c.ebner@proxmox.com/

Double checked: Dominiks patch did also cover the 'skip because vanished 
since start of sync' log message, which was not covered by my patches.




  reply	other threads:[~2026-04-27  6:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 13:35 [PATCH proxmox-backup] sync: pull: use LogLineSender in d SyncSourceReader Dominik Csapak
2026-04-24 13:37 ` Dominik Csapak
2026-04-26 21:40 ` applied: " Thomas Lamprecht
2026-04-27  6:37   ` Christian Ebner [this message]
2026-04-27  7:56     ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1e17cb3-ebfe-4e8f-a690-3ecae14fe24a@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal