* [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again
@ 2023-01-16 8:21 Dominik Csapak
2023-01-16 9:49 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-01-16 10:10 ` [pbs-devel] " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Dominik Csapak @ 2023-01-16 8:21 UTC (permalink / raw)
To: pbs-devel
while refactoring the the empty media set checks, we accidentally
reversed one check from !is_empty to unassigned, which now never
included the right media sets.
reversing the condition fixes that.
fixes
52517f7b: ("tape: hide internal use of all zero uuid for unassigned tapes")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tape/inventory.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs
index dd560179..1817ab2e 100644
--- a/src/tape/inventory.rs
+++ b/src/tape/inventory.rs
@@ -294,7 +294,7 @@ impl Inventory {
match entry.id.media_set_label {
None => continue, // not assigned to any pool
Some(ref set) => {
- if set.unassigned() {
+ if !set.unassigned() {
list.push(entry.id.clone());
}
}
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] fix #4466: show snapshots in media content again
2023-01-16 8:21 [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again Dominik Csapak
@ 2023-01-16 9:49 ` Wolfgang Bumiller
2023-01-16 10:10 ` [pbs-devel] " Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Bumiller @ 2023-01-16 9:49 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pbs-devel
applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again
2023-01-16 8:21 [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again Dominik Csapak
2023-01-16 9:49 ` [pbs-devel] applied: " Wolfgang Bumiller
@ 2023-01-16 10:10 ` Thomas Lamprecht
2023-01-16 10:52 ` Dominik Csapak
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2023-01-16 10:10 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
meh got already pushed 1:1, for the record:
misses "tape:" (or "tape inventory:") subsystem tag in subject
Am 16/01/2023 um 09:21 schrieb Dominik Csapak:
> while refactoring the the empty media set checks, we accidentally
> reversed one check from !is_empty to unassigned, which now never
> included the right media sets.
>
> reversing the condition fixes that.
>
> fixes
> 52517f7b: ("tape: hide internal use of all zero uuid for unassigned tapes")
>
Please start trailers with a capital letter and avoid extra newlines, i.e.,
after "Fixes:" (fine to go over ci message length for trailers) and between
the S-o-b .
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tape/inventory.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs
> index dd560179..1817ab2e 100644
> --- a/src/tape/inventory.rs
> +++ b/src/tape/inventory.rs
> @@ -294,7 +294,7 @@ impl Inventory {
> match entry.id.media_set_label {
> None => continue, // not assigned to any pool
> Some(ref set) => {
> - if set.unassigned() {
> + if !set.unassigned() {
> list.push(entry.id.clone());
> }
> }
I pushed out some lightly related clean ups in surrounding code I stumbled
into when preparing for pushing these, would be great if you could take
a second look to ensure I didn't overlooked something.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again
2023-01-16 10:10 ` [pbs-devel] " Thomas Lamprecht
@ 2023-01-16 10:52 ` Dominik Csapak
0 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2023-01-16 10:52 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox Backup Server development discussion
On 1/16/23 11:10, Thomas Lamprecht wrote:
> meh got already pushed 1:1, for the record:
>
> misses "tape:" (or "tape inventory:") subsystem tag in subject
>
> Am 16/01/2023 um 09:21 schrieb Dominik Csapak:
>> while refactoring the the empty media set checks, we accidentally
>> reversed one check from !is_empty to unassigned, which now never
>> included the right media sets.
>>
>> reversing the condition fixes that.
>>
>> fixes
>> 52517f7b: ("tape: hide internal use of all zero uuid for unassigned tapes")
>>
>
> Please start trailers with a capital letter and avoid extra newlines, i.e.,
> after "Fixes:" (fine to go over ci message length for trailers) and between
> the S-o-b .
sure no problem, should we include that in the developer docs?
(did not find it there)
>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> src/tape/inventory.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs
>> index dd560179..1817ab2e 100644
>> --- a/src/tape/inventory.rs
>> +++ b/src/tape/inventory.rs
>> @@ -294,7 +294,7 @@ impl Inventory {
>> match entry.id.media_set_label {
>> None => continue, // not assigned to any pool
>> Some(ref set) => {
>> - if set.unassigned() {
>> + if !set.unassigned() {
>> list.push(entry.id.clone());
>> }
>> }
>
> I pushed out some lightly related clean ups in surrounding code I stumbled
> into when preparing for pushing these, would be great if you could take
> a second look to ensure I didn't overlooked something.
sure i'll take a look
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-16 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-16 8:21 [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again Dominik Csapak
2023-01-16 9:49 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-01-16 10:10 ` [pbs-devel] " Thomas Lamprecht
2023-01-16 10:52 ` Dominik Csapak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox