public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH backup v3 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped
Date: Wed, 26 Feb 2025 22:27:06 +0100	[thread overview]
Message-ID: <c0ac1141-b880-4691-8ec0-93f6d60e9a14@proxmox.com> (raw)
In-Reply-To: <20250212105855.43853-1-f.schauer@proxmox.com>

Am 12.02.25 um 11:58 schrieb Filip Schauer:
> When wiping a block device with a GUID partition table, the header
> backup might get left behind at the end of the disk. This commit also
> wipes the last 4096 bytes of the disk, making sure that a GPT header
> backup is erased, even from disks with 4k sector sizes.
> 
> Changed since v2:
> * Split changes related to replacing calls to dd with direct file writes
>   and changes related to wiping the end of the disk into two commits.
> * Remove change to only zero out the first 1 MiB instead of the first
>   200 MiB
> 
> Changed since v1:
> * Use `std::os::unix::fs::FileExt::write_all_at` instead of calling `dd`
> * only zero out the first 1 MiB
> 
> Filip Schauer (2):
>   disks: wipe: replace dd with write_all_at for zeroing disk
>   fix #5946: disks: wipe: ensure GPT header backup is wiped
> 
>  src/tools/disks/mod.rs | 49 +++++++++++++++++++++++-------------------
>  1 file changed, 27 insertions(+), 22 deletions(-)
> 


applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2025-02-26 21:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 10:58 [pbs-devel] " Filip Schauer
2025-02-12 10:58 ` [pbs-devel] [PATCH backup v3 1/2] disks: wipe: replace dd with write_all_at for zeroing disk Filip Schauer
2025-02-12 10:58 ` [pbs-devel] [PATCH backup v3 2/2] fix #5946: disks: wipe: ensure GPT header backup is wiped Filip Schauer
2025-02-26 21:27 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0ac1141-b880-4691-8ec0-93f6d60e9a14@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal