Re: [pbs-devel] [PATCH v3 proxmox-backup 51/58] pxar: create: show chunk injection stats debug output

[Christian Ebner <c.ebner@proxmox.com>]

On 4/5/24 11:47, Fabian Grünbichler wrote:
> Quoting Christian Ebner (2024-03-28 13:37:00)
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> changes since version 2:
>> - not present in previous version
>>
>>   pbs-client/src/pxar/create.rs | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
>> index f103127c4..461509c39 100644
>> --- a/pbs-client/src/pxar/create.rs
>> +++ b/pbs-client/src/pxar/create.rs
>> @@ -407,6 +407,14 @@ where
>>       encoder.finish().await?;
>>       encoder.close().await?;
>>   
>> +    log::info!(
>> +        "Total injected: {} ({} chunks), total reused payload: {}, padding: {} ({} partial chunks)",
> 
> we already discussed this off-list, but something like
> 
> Change detection: processed XX files, YY unmodified (reused AA GB data + BB GB padding = CC GB total in DD chunks)
> 
> and only printing it with change detection metadata is probably easier to
> understand, but maybe we should get some more feedback on that as well :)
> 

Adapted this as suggested for the new version of the patches, opted 
however for splitting it into 2 lines:
- number of processed and unmodified files
- reused data, padding and total, as well as number of reused chunks and 
partial chunks

This output is now only shown when there is a payload writer available 
and the second line is not shown if there was no reused data.