From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: Show if Filter includes or excludes
Date: Thu, 30 Nov 2023 08:21:57 +0100 [thread overview]
Message-ID: <bef16e17-1da0-4e36-a7bb-4932d98f8310@proxmox.com> (raw)
In-Reply-To: <a8fe4604-3fc6-423f-8371-dd49b44a969f@proxmox.com>
On 11/28/23 14:49, Dominik Csapak wrote:
> On 11/28/23 11:40, Philipp Hufnagl wrote:
> [snip]
>> @@ -384,6 +413,82 @@ Ext.define('PBS.form.GroupFilter', {
>> },
>> });
>> +Ext.define('PBS.form.pbsGroupBehaviorSelector', {
>> + extend: 'Proxmox.form.KVComboBox',
>> + alias: 'widget.pbsGroupBehaviorSelector',
>> +
>> + allowBlank: false,
>> +
>> + comboItems: [
>> + ['include', gettext('Include')],
>> + ['exclude', gettext('Exclude')],
>> + ],
>> +});
>> +Ext.define('PBS.form.GroupFilterGrid', {
>> + extend: 'Ext.grid.Panel',
>> + alias: 'widget.pbsGroupFilterGrid',
>> +
>> + scrollable: true,
>> + height: 200,
>> + store: {
>> + fields: ['type', 'input'],
>> + },
>> + columns: [
>> + {
>> + text: gettext('Filter Type'),
>> + xtype: 'widgetcolumn',
>> + dataIndex: 'type',
>> + flex: 1,
>> + widget: {
>> + xtype: 'pbsGroupFilterTypeSelector',
>> + isFormField: false,
>> + },
>> + },
>> + {
>> + text: gettext('Filter Value'),
>> + xtype: 'widgetcolumn',
>> + flex: 1,
>> + onWidgetAttach: 'newInputColumn',
>> + widget: {
>> + padding: 0,
>> + bodyPadding: 0,
>> + xtype: 'fieldcontainer',
>> + layout: 'fit',
>> + defaults:
>> + {
>> + margin: 0,
>> + },
>> + items: [
>> + {
>> + hidden: true,
>> + xtype: 'pbsGroupTypeSelector',
>> + isFormField: false,
>> + },
>> + {
>> + hidden: true,
>> + xtype: 'textfield',
>> + type: 'regex',
>> + isFormField: false,
>> + },
>> + {
>> + hidden: true,
>> + xtype: 'pbsGroupSelector',
>> + isFormField: false,
>> + },
>> + ],
>> + },
>> + },
>> + {
>> + xtype: 'widgetcolumn',
>> + width: 30,
>
> here you change the width of the remove button, which makes it too narrow
> and cuts of the icon, please leave the space of this the same as before
Ah thank you! I was wondering about that. I did not want to change it
because I did not touch the vertical sizes anywhere else.
I'll make a new version!
>
>> + widget: {
>> + xtype: 'button',
>> + iconCls: 'fa fa-trash-o',
>> + },
>> + },
>> + ],
>> +});
>> +
>> Ext.define('PBS.form.GroupFilterTypeSelector', {
>> extend: 'Proxmox.form.KVComboBox',
>> alias: 'widget.pbsGroupFilterTypeSelector',
>
>
next prev parent reply other threads:[~2023-11-30 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 10:40 [pbs-devel] [PATCH proxmox-backup v3 0/3] [PATCH proxmox-backup v2 0/3] fix #4315: datastore: Exclude entries from sync Philipp Hufnagl
2023-11-28 10:40 ` [pbs-devel] [PATCH proxmox-backup v3 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-11-28 12:52 ` Lukas Wagner
2023-11-28 10:40 ` [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-11-28 13:49 ` Dominik Csapak
2023-11-30 7:21 ` Philipp Hufnagl [this message]
2023-11-28 10:40 ` [pbs-devel] [PATCH proxmox-backup v3 3/3] docs: document new include/exclude paramenter Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef16e17-1da0-4e36-a7bb-4932d98f8310@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox