public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v5 8/9] ui: add move namespace action
Date: Tue, 31 Mar 2026 14:29:37 +0200	[thread overview]
Message-ID: <be0ed635-395d-4fbb-b2a1-acbfe90c53be@proxmox.com> (raw)
In-Reply-To: <2290f062-22b9-48ae-b43c-9e7bca683497@proxmox.com>

On 2026-03-24 11:56, Dominik Csapak wrote:
> looks mostly fine
> 
> preexisting but slightly confusing:
> 
> the action of a namespace can only be done from that namespace itself,
> not from one level above. maybe it would be sensible to make
> that possible as well?
> 
> otherwise one comment inline
> 
> On 3/19/26 5:13 PM, Hannes Laimer wrote:
>> When moving a namespace, exclude the source namespace and its subtree
>> from the 'New Parent' selector.
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---

[..]

>>   @@ -1113,10 +1135,13 @@ Ext.define('PBS.DataStoreContent', {
>>                           if (data.ty === 'group') {
>>                               return Ext.String.format(gettext("Move
>> group '{0}'"), v);
>>                           }
>> -                        return '';
>> +                        return Ext.String.format(gettext("Move
>> namespace '{0}'"), v);
> 
> this tooltip is shown for all entries when hovering, even when he icon
> is not visible, probably due to it never being disabled
> 
> i think verify and remove have the same problem...
> 

yup, they do. can do a follow-up




  parent reply	other threads:[~2026-03-31 12:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 16:13 [PATCH proxmox-backup v5 0/9] fixes #6195: add support for moving groups and namespaces Hannes Laimer
2026-03-19 16:13 ` [PATCH proxmox-backup v5 1/9] ui: show empty groups Hannes Laimer
2026-03-24 10:28   ` Dominik Csapak
2026-03-19 16:13 ` [PATCH proxmox-backup v5 2/9] datastore: add namespace-level locking Hannes Laimer
2026-03-24 13:00   ` Fabian Grünbichler
2026-03-19 16:13 ` [PATCH proxmox-backup v5 3/9] datastore: add move_group Hannes Laimer
2026-03-24 13:00   ` Fabian Grünbichler
2026-03-25  6:20     ` Hannes Laimer
2026-03-19 16:13 ` [PATCH proxmox-backup v5 4/9] datastore: add move_namespace Hannes Laimer
2026-03-24 13:00   ` Fabian Grünbichler
2026-03-25  6:32     ` Hannes Laimer
2026-03-25  8:55       ` Fabian Grünbichler
2026-03-19 16:13 ` [PATCH proxmox-backup v5 5/9] api: add PUT endpoint for move_group Hannes Laimer
2026-03-19 16:13 ` [PATCH proxmox-backup v5 6/9] api: add PUT endpoint for move_namespace Hannes Laimer
2026-03-19 16:13 ` [PATCH proxmox-backup v5 7/9] ui: add move group action Hannes Laimer
2026-03-24 10:41   ` Dominik Csapak
2026-03-19 16:13 ` [PATCH proxmox-backup v5 8/9] ui: add move namespace action Hannes Laimer
2026-03-24 10:56   ` Dominik Csapak
2026-03-31 12:27     ` Hannes Laimer
2026-03-31 12:29     ` Hannes Laimer [this message]
2026-03-19 16:13 ` [PATCH proxmox-backup v5 9/9] cli: add move-namespace and move-group commands Hannes Laimer
2026-03-31 12:34 ` superseded: [PATCH proxmox-backup v5 0/9] fixes #6195: add support for moving groups and namespaces Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0ed635-395d-4fbb-b2a1-acbfe90c53be@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal