From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api types: fix non-capturing group syntax
Date: Thu, 6 Apr 2023 07:29:55 +0200 [thread overview]
Message-ID: <be04fa47-c212-c1db-bdb6-6bb828666d88@proxmox.com> (raw)
In-Reply-To: <20230330072042.457208-1-d.csapak@proxmox.com>
Am 30/03/2023 um 09:20 schrieb Dominik Csapak:
> a non capturing group is '(?:)' not '(:?)' so fix that.
> None of these regexes are used where would use capturing groups.
> DATASTORE_MAP_REGEX and TAPE_RESTORE_SNAPSHOT_REGEX are only used
> as api types and BLOCKDEVICE_NAME_REGEX is only used once outside of the
> api and there we also don't look at the capturing groups.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> pbs-api-types/src/datastore.rs | 2 +-
> pbs-api-types/src/lib.rs | 2 +-
> pbs-api-types/src/tape/mod.rs | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-04-06 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 7:20 [pbs-devel] " Dominik Csapak
2023-04-06 5:29 ` Thomas Lamprecht [this message]
2023-04-06 5:33 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be04fa47-c212-c1db-bdb6-6bb828666d88@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox