From: Filip Schauer <f.schauer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5946: api: disks: directory: fix unknown task status when partition creation fails
Date: Mon, 11 Aug 2025 15:03:09 +0200 [thread overview]
Message-ID: <bc91d038-0b3b-45c2-bf5f-28975663d946@proxmox.com> (raw)
In-Reply-To: <1749036426.pl3wdn7yca.astroid@yuna.none>
On 04/06/2025 13:28, Fabian Grünbichler wrote:
> On April 22, 2025 5:03 pm, Filip Schauer wrote:
>> This shows a more helpful error status than "unknown", when the
>> directory creation task fails during creation of the partition on disk.
>> The full error message can still be viewed in the task log.
>>
>> Signed-off-by: Filip Schauer<f.schauer@proxmox.com>
>> ---
>> Is there a cleaner way to handle this?
> I am not sure I understand the issue - is {err} sometimes just
> "unknown"? I think then improving that error message would make more
> sense..
>
> or how does replacing one Error with another Error fix the problem?
The real problem was that the task status could not be detected when the
error message spanned over multiple lines, since only the last line was
inspected.
Patch v2 fixes the task status detection for multi-line log messages.
Superseded by:
https://lore.proxmox.com/pbs-devel/20250811125839.267803-1-f.schauer@proxmox.com/T
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-11 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 15:03 Filip Schauer
2025-06-04 11:28 ` Fabian Grünbichler
2025-08-11 13:03 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc91d038-0b3b-45c2-bf5f-28975663d946@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox