public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: metricserver: fix enable column
@ 2022-11-29 12:01 Dominik Csapak
  2022-11-30 16:45 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-11-29 12:01 UTC (permalink / raw)
  To: pbs-devel

we use 'enable' property here with a default of true, so change
the dataIndex and the renderer to reflect that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/config/MetricServerView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/config/MetricServerView.js b/www/config/MetricServerView.js
index 5aaf81b6..c7c786fd 100644
--- a/www/config/MetricServerView.js
+++ b/www/config/MetricServerView.js
@@ -65,9 +65,9 @@ Ext.define('PBS.config.MetricServerView', {
 	},
 	{
 	    text: gettext('Enabled'),
-	    dataIndex: 'disable',
+	    dataIndex: 'enable',
 	    width: 100,
-	    renderer: Proxmox.Utils.format_neg_boolean,
+	    renderer: v => Proxmox.Utils.format_boolean(v ?? true),
 	},
 	{
 	    text: gettext('Target Server'),
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: metricserver: fix enable column
  2022-11-29 12:01 [pbs-devel] [PATCH proxmox-backup] ui: metricserver: fix enable column Dominik Csapak
@ 2022-11-30 16:45 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-30 16:45 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

Am 29/11/2022 um 13:01 schrieb Dominik Csapak:
> we use 'enable' property here with a default of true, so change
> the dataIndex and the renderer to reflect that
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/config/MetricServerView.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-30 16:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 12:01 [pbs-devel] [PATCH proxmox-backup] ui: metricserver: fix enable column Dominik Csapak
2022-11-30 16:45 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal