From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] tape/pool_writer: skip already backed up chunks in iterator
Date: Fri, 18 Feb 2022 10:45:09 +0100 [thread overview]
Message-ID: <ba9c70e9-1029-308c-bbf3-1e0cd3941778@proxmox.com> (raw)
In-Reply-To: <20220217135040.512359-1-d.csapak@proxmox.com>
applied with minor cleanups..
On 2/17/22 14:50, Dominik Csapak wrote:
> currently, the iterator goes over *all* chunks of the index, even
> those already backed up by a previous snapshots in the same tape
> backup. this is bad since for each iterator, we stat each chunk to
> sort by inode number. so to avoid stat'ing the same chunks over
> and over for consecutive snapshots, add a 'skip_fn' to the iterator
> and in the pool writer and check the catalog_set if we can skip it
>
> this means we can drop the later check for the catalog_set
> (since we don't modify that here)
prev parent reply other threads:[~2022-02-18 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 13:50 [pbs-devel] " Dominik Csapak
2022-02-18 9:45 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9c70e9-1029-308c-bbf3-1e0cd3941778@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox