From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: Re: [PATCH proxmox] rest-server: accept empty body as valid parameters
Date: Thu, 7 Sep 2023 18:15:33 +0200 [thread overview]
Message-ID: <b9069c2f-c169-4d9a-a1bd-3fb2d5ea2256@proxmox.com> (raw)
In-Reply-To: <20230824102231.4085335-1-d.csapak@proxmox.com>
On 24/08/2023 12:22, Dominik Csapak wrote:
> technically an empty string is not valid json, but when sending an api
> request without any parameters, treating the empty body as an empty
> parameter hash instead of an error, makes the the api more robust for
> clients
yeah, it's practical to do that. While not directly related, we do the same
for the manager_status in the pve-ha-manager.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> proxmox-rest-server/src/rest.rs | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-09-07 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 10:22 [pbs-devel] " Dominik Csapak
2023-09-07 16:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9069c2f-c169-4d9a-a1bd-3fb2d5ea2256@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox