Re: [pbs-devel] [PATCH proxmox-backup 2/3] ui: onlinehelp update with sysadmin_host_administration

[Aaron Lauterer <a.lauterer@proxmox.com>]

This was phrased a bit confusing. This was not removed manually but when I ran a `make OnlineHelpInfo.js` they were removed.
So yeah, no idea why they were added in the first place but there is something going on that I do not fully understand yet but definitely a result of the quick hack to not scan the JS source files for help keys that are actually in use.



On 11/10/20 1:53 PM, Thomas Lamprecht wrote:
> On 10.11.20 13:38, Aaron Lauterer wrote:
>> also remove some rst refs that slipped in
>>
> 
> why?? this is an autogenerated file which we want to track in git, nothing slipped
> in here. Do not remove things manually which then just get re-added on each make
> OnlineHelpInfo call, producing a dirty git state..
> 
> I dropped the wrong removes, the correct fix for this is to fix the onlineHelp
> scanner, which then drops this automatically.
> 
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   www/OnlineHelpInfo.js | 40 ++++------------------------------------
>>   1 file changed, 4 insertions(+), 36 deletions(-)
>>
>> diff --git a/www/OnlineHelpInfo.js b/www/OnlineHelpInfo.js
>> index a9683874..c54912d8 100644
>> --- a/www/OnlineHelpInfo.js
>> +++ b/www/OnlineHelpInfo.js
>> @@ -75,42 +75,6 @@ const proxmoxOnlineHelpInfo = {
>>       "link": "/docs/pve-integration.html#pve-integration",
>>       "title": "`Proxmox VE`_ Integration"
>>     },
>> -  "rst-primer": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-primer",
>> -    "title": "reStructuredText Primer"
>> -  },
>> -  "rst-inline-markup": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-inline-markup",
>> -    "title": "Inline markup"
>> -  },
>> -  "rst-literal-blocks": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-literal-blocks",
>> -    "title": "Literal blocks"
>> -  },
>> -  "rst-doctest-blocks": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-doctest-blocks",
>> -    "title": "Doctest blocks"
>> -  },
>> -  "rst-tables": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-tables",
>> -    "title": "Tables"
>> -  },
>> -  "rst-field-lists": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-field-lists",
>> -    "title": "Field Lists"
>> -  },
>> -  "rst-roles-alt": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-roles-alt",
>> -    "title": "Roles"
>> -  },
>> -  "rst-directives": {
>> -    "link": "/docs/reStructuredText-primer.html#rst-directives",
>> -    "title": "Directives"
>> -  },
>> -  "html-meta": {
>> -    "link": "/docs/reStructuredText-primer.html#html-meta",
>> -    "title": "HTML Metadata"
>> -  },
>>     "storage-disk-management": {
>>       "link": "/docs/storage.html#storage-disk-management",
>>       "title": "Disk Management"
>> @@ -123,6 +87,10 @@ const proxmoxOnlineHelpInfo = {
>>       "link": "/docs/storage.html#storage-datastore-create",
>>       "title": "Creating a Datastore"
>>     },
>> +  "sysadmin-host-administration": {
>> +    "link": "/docs/sysadmin.html#sysadmin-host-administration",
>> +    "title": "Host System Administration"
>> +  },
>>     "user-mgmt": {
>>       "link": "/docs/user-management.html#user-mgmt",
>>       "title": "User Management"
>>
> 
>