public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v2 proxmox-backup 0/3] close #3459: add --ignore-verified and --outdated-after to CLI and api2
Date: Mon, 28 Jun 2021 11:29:04 +0200	[thread overview]
Message-ID: <b6013f3f-fb7b-d5c0-97c5-3e7e5fc3bf3a@proxmox.com> (raw)
In-Reply-To: <20210622075620.28681-1-h.laimer@proxmox.com>

On 22.06.21 09:56, Hannes Laimer wrote:
> v2, based on Dominik Csapak <d.csapak@proxmox.com>'s feedback:
>  - new function is now the filter, instead of returning a closure
>  - used extract_output_format in the binary
> 
> 
> Moved the snapshot filter into a function, so verify jobs and 
> the datastore verify endpoint don't have duplicated code. Also adds
> --ignore-verified and --outdated-after to the CLI and api2 endpoint for
> verifing datastores.
> It might make sense to also make those option avaiable in the WebUI.
> 
> Hannes Laimer (3):
>   close #3459: verify-job: move snapshot filter into function
>   close #3459: api2: add ignore-verified and outdated-after to datastore
>     verify endpoint
>   close: #3459: manager_bin: add --ignore-verified and --outdated-after
>     parameters
> 
>  src/api2/admin/datastore.rs       | 28 +++++++++++++++++++++++---
>  src/backup/verify.rs              | 27 +++++++++++++++++++++++++
>  src/bin/proxmox-backup-manager.rs | 14 ++++++++++---
>  src/server/verify_job.rs          | 33 +++++++++----------------------
>  4 files changed, 72 insertions(+), 30 deletions(-)
> 



applied, thanks! Adapted  some comment messages do not falsely state to fix
an bugzilla entry they do not actively fix and added Dominik's T-b/R-b tags.




      parent reply	other threads:[~2021-06-28  9:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  7:56 [pbs-devel] " Hannes Laimer
2021-06-22  7:56 ` [pbs-devel] [PATCH v2 proxmox-backup 1/3] close #3459: verify-job: move snapshot filter into function Hannes Laimer
2021-06-22  9:56   ` Thomas Lamprecht
2021-06-22  7:56 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] close #3459: api2: add ignore-verified and outdated-after to datastore verify endpoint Hannes Laimer
2021-06-22  7:56 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] close #3459: manager_bin: add --ignore-verified and --outdated-after parameters Hannes Laimer
2021-06-25 11:13 ` [pbs-devel] [PATCH v2 proxmox-backup 0/3] close #3459: add --ignore-verified and --outdated-after to CLI and api2 Dominik Csapak
2021-06-28  9:29 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6013f3f-fb7b-d5c0-97c5-3e7e5fc3bf3a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal