From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup 0/12] pull/sync group filter
Date: Thu, 18 Nov 2021 11:11:32 +0100 [thread overview]
Message-ID: <b47dbeb1-cad8-a275-b5d6-302c42a1f45f@proxmox.com> (raw)
In-Reply-To: <20211028130058.1308810-1-f.gruenbichler@proxmox.com>
On 28.10.21 15:00, Fabian Grünbichler wrote:
> this has been requested a few times on the forum, e.g. for a special
> sync job for the most important groups, or seeding of a new datastore
> with a partial view of an existing one.
>
> while it's possible to achieve similar results with hacky workarounds
> based on group ownership and reduced "visibility", implementing it
> properly is not that complex.
>
> possible future additions in a similar fashion:
> - exclude filters
> - filtering in other API calls (tape, listing groups/snapshots)
> - only sync/pull encrypted snapshots (less trusted off-site
> location)
> - only sync/pull latest snapshot in each group (fast seeding of new
> datastore)
>
> not changed: BackupGroup was not pulled into api-types - we can still
> re-evaluate this at some point if we want to switch the split api
> parameters we currently have, but at the moment this would mean lots of
> churn for a very small gain.
>
> changed since v2:
> - implement UpdaterType for Vec<T> in proxmox-schema, simplify proxmox-backup patches
> - pull parameters into struct
> - added patch for flipped remove-vanished default
>
> changed since v1:
> - reworked filter to support different types, rebased
> - dropped last patch
> - add docs patch
>
> proxmox:
>
> Fabian Grünbichler (1):
> updater: impl UpdaterType for Vec
>
> proxmox-schema/src/schema.rs | 5 +++++
> 1 file changed, 5 insertions(+)
>
> proxmox-backup:
>
> Fabian Grünbichler (11):
> api-types: add schema for backup group
> api: add GroupFilter(List) type
> BackupGroup: add filter helper
> pull: use BackupGroup consistently
> pull/sync: extract passed along vars into struct
> pull: allow pulling groups selectively
> sync: add group filtering
> remote: add backup group scanning
> manager: render group filter properly
> docs: mention group filter in sync docs
> fix #sync.cfg/pull: don't remove by default
>
> docs/managing-remotes.rst | 6 +
> debian/postinst | 31 ++++++
> pbs-api-types/src/datastore.rs | 5 +
> pbs-api-types/src/jobs.rs | 64 ++++++++++-
> pbs-datastore/src/backup_info.rs | 13 +++
> src/api2/config/remote.rs | 77 ++++++++++++-
> src/api2/config/sync.rs | 5 +
> src/api2/pull.rs | 70 ++++++------
> src/bin/proxmox-backup-manager.rs | 117 +++++++++++++++++--
> src/bin/proxmox_backup_manager/sync.rs | 21 ++++
> src/server/pull.rs | 148 ++++++++++++++++++-------
> www/config/SyncView.js | 13 ++-
> www/window/SyncJobEdit.js | 12 ++
> 13 files changed, 487 insertions(+), 95 deletions(-)
>
applied series, thanks!
Made two follow ups:
- renamed `groups` to `group-filter` (please verify that nothing bogus was done)
- restructured the docs slightly and added a `type` and `group` example
prev parent reply other threads:[~2021-11-18 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 13:00 [pbs-devel] " Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox 1/1] updater: impl UpdaterType for Vec Fabian Grünbichler
2021-11-09 8:31 ` [pbs-devel] applied: " Dietmar Maurer
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 01/11] api-types: add schema for backup group Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 02/11] api: add GroupFilter(List) type Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 03/11] BackupGroup: add filter helper Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 04/11] pull: use BackupGroup consistently Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 05/11] pull/sync: extract passed along vars into struct Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 06/11] pull: allow pulling groups selectively Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 07/11] sync: add group filtering Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 08/11] remote: add backup group scanning Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 09/11] manager: render group filter properly Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [PATCH v3 proxmox-backup 10/11] docs: mention group filter in sync docs Fabian Grünbichler
2021-10-28 13:00 ` [pbs-devel] [RFC v3 proxmox-backup 11/11] fix #sync.cfg/pull: don't remove by default Fabian Grünbichler
2021-11-04 9:57 ` [pbs-devel] [PATCH v3 proxmox-backup 0/12] pull/sync group filter Dominik Csapak
2021-11-18 10:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47dbeb1-cad8-a275-b5d6-302c42a1f45f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox