public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress
Date: Fri, 18 Oct 2024 14:13:55 +0200	[thread overview]
Message-ID: <b39c3db3-2427-4108-b453-4b2c3c707ac5@proxmox.com> (raw)
In-Reply-To: <a2bf940b-6acb-4955-8914-7d9ccfc126f1@proxmox.com>

Am 18/10/2024 um 10:33 schrieb Christian Ebner:
> On 10/18/24 09:53, Thomas Lamprecht wrote:
>> Minus the s/opt-in/opt-out/ preference that's fine by me. We could then
>> also switch to a higher reporting rate in PVE, albeit FWIW, for VM backups
>> there we use 10s and then slow down after some time, trying to take a
>> balance for early fast feedback and short backups and long backups.
>> And just throwing out ideas, one could also do a size-related interval,
>> like print a report every (at least) X MB or GB uploaded.
> 
> Hmm, that would be nice to have, maybe allow to pass either a `TimeSpan` 
> or a `HumanByte` for the log interval parameter? Not sure if parsing 
> would work without possible value clashes though (e.g. 4M could be 4 
> months or 4 MiB...).
> 
> But maybe that is overkill and not so user friendly, the better option 
> being to set either time or size based intervals by (yet another) flag.
> 

Yeah, if we do this I'd probably separate it by type, as while it might
work out for this specific one mixing units can get confusing fast in
general.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2024-10-18 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  9:33 [pbs-devel] [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end Christian Ebner
2024-10-11  9:33 ` [pbs-devel] [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress Christian Ebner
2024-10-17 15:02   ` [pbs-devel] applied: " Thomas Lamprecht
2024-10-17 15:53     ` Christian Ebner
2024-10-18  7:20       ` Thomas Lamprecht
2024-10-18  7:37         ` Christian Ebner
2024-10-18  7:53           ` Thomas Lamprecht
2024-10-18  8:33             ` Christian Ebner
2024-10-18 12:13               ` Thomas Lamprecht [this message]
2024-10-17 13:16 ` [pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end Thomas Lamprecht
2024-10-17 14:40   ` Christian Ebner
2024-10-18 12:12     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b39c3db3-2427-4108-b453-4b2c3c707ac5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal