Re: [PATCH proxmox v5 05/13] s3-client: add counters for upload/download traffic

[Christian Ebner <c.ebner@proxmox.com>]

On 3/12/26 3:28 PM, Hannes Laimer wrote:
> do we want to also `reset` bytes, cause the reset api endpoint does not
> currently? We have thresholds, but we don't seem to check them, so no I
> guess. On the other hand, given the current implementation it looks like
> they are intended to behave like the counter ones.

Yes, indeed! The uploaded/downloaded traffic should be reset as well, 
will adapt that, thanks! In general, I still plan to include a schedule 
based resetting, so users can configure to e.g. perform a monthly reset 
of the counters.

> 
> 
> On 2026-03-11 14:08, Christian Ebner wrote:
>> In addition to accounting for requests, also allow to track the
>> number of bytes uploaded or downloaded via the s3 clients.
>>
>> With the intention to estimate shared upload/download bandwidth in
>> Proxmox Backup Server as well as easily estimate the total traffic
>> volume.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>>   .../src/shared_request_counters.rs            | 63 +++++++++++++++++++
>>   1 file changed, 63 insertions(+)
>>
>> diff --git a/proxmox-s3-client/src/shared_request_counters.rs b/proxmox-s3-client/src/shared_request_counters.rs
>> index edd1df3d..a5cd286c 100644
>> --- a/proxmox-s3-client/src/shared_request_counters.rs
>> +++ b/proxmox-s3-client/src/shared_request_counters.rs
>> @@ -37,6 +37,9 @@ struct RequestCounters {
>>       put: AlignedAtomic,
>>       head: AlignedAtomic,
>>       post: AlignedAtomic,
>> +    // traffic in bytes
>> +    upload: AlignedAtomic,
>> +    download: AlignedAtomic,
>>   }
>>   
>>   impl Init for RequestCounters {
>> @@ -81,6 +84,30 @@ impl RequestCounters {
>>           self.post.0.store(0, ordering);
>>           self.put.0.store(0, ordering);
>>       }
>> +
>> +    /// Account for new upload traffic.
>> +    ///
>> +    /// Returns the previously stored value.
>> +    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
>> +        self.upload.0.fetch_add(count, ordering)
>> +    }
>> +
>> +    /// Returns upload traffic count.
>> +    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
>> +        self.upload.0.load(ordering)
>> +    }
>> +
>> +    /// Account for new download traffic.
>> +    ///
>> +    /// Returns the previously stored value.
>> +    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
>> +        self.download.0.fetch_add(count, ordering)
>> +    }
>> +
>> +    /// Returns download traffic count.
>> +    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
>> +        self.download.0.load(ordering)
>> +    }
>>   }
>>   
>>   /// Size of the padding to align the mmapped request counters to 4k default
>> @@ -180,4 +207,40 @@ impl SharedRequestCounters {
>>       pub fn reset(&self, ordering: Ordering) {
>>           self.shared_memory.data().counters.reset(ordering)
>>       }
>> +
>> +    /// Account for new upload traffic.
>> +    ///
>> +    /// Returns the previously stored value.
>> +    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
>> +        self.shared_memory
>> +            .data()
>> +            .counters
>> +            .add_upload_traffic(count, ordering)
>> +    }
>> +
>> +    /// Returns upload traffic count.
>> +    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
>> +        self.shared_memory
>> +            .data()
>> +            .counters
>> +            .get_upload_traffic(ordering)
>> +    }
>> +
>> +    /// Account for new download traffic.
>> +    ///
>> +    /// Returns the previously stored value.
>> +    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
>> +        self.shared_memory
>> +            .data()
>> +            .counters
>> +            .add_download_traffic(count, ordering)
>> +    }
>> +
>> +    /// Returns download traffic count.
>> +    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
>> +        self.shared_memory
>> +            .data()
>> +            .counters
>> +            .get_download_traffic(ordering)
>> +    }
>>   }
>