public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Nicolas Frey <n.frey@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 6/6] ui: verify: add option to set number of threads for job
Date: Tue, 11 Nov 2025 11:22:31 +0100	[thread overview]
Message-ID: <b249cc4c-f6ab-4016-87e3-244f8fff9301@proxmox.com> (raw)
In-Reply-To: <20251110084417.173290-10-n.frey@proxmox.com>


Reviewed-by: Christian Ebner <c.ebner@proxmox.com>

On 11/10/25 9:44 AM, Nicolas Frey wrote:
> Exposes the {read,verify}-threads property in the `VerifyJobEdit`
> window and `VerifyAll` window so the user can update the values
> accordingly.
> 
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   www/window/VerifyAll.js     | 18 ++++++++++++++++++
>   www/window/VerifyJobEdit.js | 24 ++++++++++++++++++++++++
>   2 files changed, 42 insertions(+)
> 
> diff --git a/www/window/VerifyAll.js b/www/window/VerifyAll.js
> index 01bcd63d..4239c215 100644
> --- a/www/window/VerifyAll.js
> +++ b/www/window/VerifyAll.js
> @@ -80,6 +80,24 @@ Ext.define('PBS.window.VerifyAll', {
>                           },
>                       ],
>                   },
> +                {
> +                    xtype: 'proxmoxintegerfield',
> +                    name: 'read-threads',
> +                    fieldLabel: gettext('# of Read Threads'),
> +                    emptyText: '1',
> +                    skipEmptyText: true,
> +                    minValue: 1,
> +                    maxValue: 32,
> +                },
> +                {
> +                    xtype: 'proxmoxintegerfield',
> +                    name: 'verify-threads',
> +                    fieldLabel: gettext('# of Verify Threads'),
> +                    emptyText: '4',
> +                    skipEmptyText: true,
> +                    minValue: 1,
> +                    maxValue: 32,
> +                },
>               ],
>           },
>       ],
> diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
> index e87ca069..5650ed5c 100644
> --- a/www/window/VerifyJobEdit.js
> +++ b/www/window/VerifyJobEdit.js
> @@ -154,6 +154,30 @@ Ext.define('PBS.window.VerifyJobEdit', {
>               },
>           ],
>           advancedColumn1: [
> +            {
> +                xtype: 'proxmoxintegerfield',
> +                name: 'read-threads',
> +                fieldLabel: gettext('# of Read Threads'),
> +                emptyText: '1',
> +                minValue: 1,
> +                maxValue: 32,
> +                cbind: {
> +                    deleteEmpty: '{!isCreate}',
> +                },
> +            },
> +            {
> +                xtype: 'proxmoxintegerfield',
> +                name: 'verify-threads',
> +                fieldLabel: gettext('# of Verify Threads'),
> +                emptyText: '4',
> +                minValue: 1,
> +                maxValue: 32,
> +                cbind: {
> +                    deleteEmpty: '{!isCreate}',
> +                },
> +            },
> +        ],
> +        advancedColumn2: [
>               {
>                   xtype: 'pmxDisplayEditField',
>                   fieldLabel: gettext('Job ID'),



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-11-11 10:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10  8:44 [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification Nicolas Frey
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox v3 1/3] pbs-api-types: add schema for {worker, read, verify}-threads Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox v3 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox v3 3/3] pbs-api-types: use worker-threads schema for TapeBackupJobSetup Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 1/6] api: verify: move chunk loading into parallel handler Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 2/6] api: verify: bundle parameters into new struct Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 3/6] api: verify: determine the number of threads to use with {read, verify}-threads Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 4/6] api: verify: correct typo in comment Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 5/6] api: verify: add {read, verify}-threads to update endpoint Nicolas Frey
2025-11-11 10:22   ` Christian Ebner
2025-11-10  8:44 ` [pbs-devel] [PATCH proxmox-backup v3 6/6] ui: verify: add option to set number of threads for job Nicolas Frey
2025-11-11 10:22   ` Christian Ebner [this message]
2025-11-11 10:21 ` [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification Christian Ebner
2025-11-11 10:35   ` Nicolas Frey
2025-11-13  9:33 ` [pbs-devel] superseded: " Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b249cc4c-f6ab-4016-87e3-244f8fff9301@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=n.frey@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal