From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter includes or excludes
Date: Tue, 24 Oct 2023 14:20:24 +0200 [thread overview]
Message-ID: <b0e48ab1-7d31-49cb-b133-bb618ab0e493@proxmox.com> (raw)
In-Reply-To: <20231023154302.2558918-3-p.hufnagl@proxmox.com>
On 10/23/23 17:43, Philipp Hufnagl wrote:
> @@ -163,8 +183,12 @@ Ext.define('PBS.form.GroupFilter', {
>
> let filter = [];
> me.lookup('grid').getStore().each((rec) => {
> - if (rec.data.type && rec.data.input) {
> - filter.push(`${rec.data.type}:${rec.data.input}`);
> + if (rec.data.type && rec.data.input && rec.data.behaviour) {
> + let behaviour_string = '';
> + if (rec.data.behaviour === 'exclude') {
> + behaviour_string = 'exclude:';
^
should be in camelCase, according to our JS Style guide
> + }
> + filter.push(`${behaviour_string}${rec.data.type}:${rec.data.input}`);
> }
> });
>
--
- Lukas
next prev parent reply other threads:[~2023-10-24 12:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 15:42 [pbs-devel] [PATCH proxmox-backup 0/3] fix #4315: datastore: Exclude entries from sync Philipp Hufnagl
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-10-24 9:18 ` Lukas Wagner
2023-10-24 9:54 ` Philipp Hufnagl
2023-10-24 10:43 ` Lukas Wagner
2023-10-24 14:32 ` Philipp Hufnagl
2023-10-25 13:33 ` Thomas Lamprecht
2023-10-25 15:07 ` Philipp Hufnagl
2023-10-25 15:45 ` Thomas Lamprecht
2023-11-07 7:43 ` Wolfgang Bumiller
2023-11-07 7:55 ` Thomas Lamprecht
2023-11-07 8:26 ` Wolfgang Bumiller
2023-11-07 9:01 ` Dominik Csapak
2023-11-07 11:10 ` Thomas Lamprecht
2023-11-07 11:07 ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-10-24 12:20 ` Lukas Wagner [this message]
2023-10-24 12:27 ` Lukas Wagner
2023-10-24 12:36 ` Philipp Hufnagl
2023-10-24 14:09 ` Philipp Hufnagl
2023-10-24 14:12 ` Lukas Wagner
2023-10-27 9:29 ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/3] docs: document new include/exclude paramenter Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e48ab1-7d31-49cb-b133-bb618ab0e493@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox