Re: [pbs-devel] [PATCH proxmox 1/2] http: factor out PBS shared rate limiter implementation

[Christian Ebner <c.ebner@proxmox.com>]

On 9/15/25 9:10 PM, Thomas Lamprecht wrote:
> Am 28.08.25 um 12:26 schrieb Christian Ebner:
>> Moves the current shared rate limiter implementation from the Proxmox
>> Backup Server into proxmox-http for it to be reusable, e.g. for s3
>> client rate limiting.
> 
> Two things:
> 1. There is still the PROXMOX_BACKUP_SHARED_RATE_LIMITER_MAGIC_1_0 references
>     to PBS that should be made generic in naming, otherwise it might be confusing.

Okay, as mentioned in the note to the patch I was a bit unsure if this 
could cause some backwards compatibility issues, so I did not adapt it.

But as discussed off-list, will adapt the constant name and note this in 
the comment to avoid future confusion on why this value was generated as is.

> 2. Should the this and the existing RateLimiter go into their own crate? They
>     are not really tied to being used with HTTP after all, token bucket filter
>     are a rather generic concept and besides the central module entry point lib.rs
>     you do not touch any file from the crate here. What do you think?

Yes, will see to move this to a dedicated crate then.

Thanks a lot for feedback!



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel