Re: [pbs-devel] [PATCH proxmox-backup v2 4/5] ui: tape/window/TapeRestore: enabling selecting multiple snapshots

[Dominik Csapak <d.csapak@proxmox.com>]

On 5/18/21 7:00 PM, Thomas Lamprecht wrote:
> On 18.05.21 09:00, Thomas Lamprecht wrote:
>> On 14.05.21 14:59, Dominik Csapak wrote:
>>> by including the new snapshotselector. If a whole media-set is to be
>>> restored, select all snapshots
>>>
>>> to achieve this, we drop the 'restoreid' and 'datastores' properties
>>> for the restore window, and replace them by a 'prefilter' object
>>> (with 'store' and 'snapshot' properties)
>>>
>>> to be able to show the snapshots, we now have to always load the
>>> content of that media-set, so drop the short-circuit if we have
>>> the datastores already.
>>>
>>> also to improve space-usage, shift the datastores mapping grid in the
>>> right column, and all non datastore related options in the left one,
>>> showing the snapshot grid below
>>> (the datastore mapping is now limited to 150px; ~3 datastores, and scrollable)
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>> ---
>>>   www/tape/BackupOverview.js     | 27 +++-------
>>>   www/tape/window/TapeRestore.js | 99 ++++++++++++++++++----------------
>>>   2 files changed, 61 insertions(+), 65 deletions(-)
>>>
>>
> 
> Oh, and before I forget it, it irked me a bit that the content tree's expansion
> state was not restored after the store reloaded triggered due to the restore
> edit-window getting closed, all just got collapsed again.
> Maybe you can improve that? I'm not even sure that a reload is useful after the
> close, as any tape-restore itself did not alter the content there.
> 

yes you're right, restore should not trigger a reload

as for keeping the expanded state on a reload, i'll have to check how
much work that is. it's a bit different than e.g. the datastore content,
since we here have separate api calls for the first and subsequent 
levels, so to check for differences gets a bit more complicated and
possibly more expensive in terms of api calls