From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: add node options under 'Configuration -> Options'
Date: Tue, 25 May 2021 07:52:58 +0200 [thread overview]
Message-ID: <ae194062-50f3-0c34-87d9-ec5ed4296821@proxmox.com> (raw)
In-Reply-To: <20210512144232.5643-1-d.csapak@proxmox.com>
On 12.05.21 16:42, Dominik Csapak wrote:
> for now only http-proxy lives there, but we will add more options later,
> such as
> * email from
> * default gui language
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/Makefile | 1 +
> www/SystemConfiguration.js | 5 +++++
> www/config/NodeOptionView.js | 42 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 48 insertions(+)
> create mode 100644 www/config/NodeOptionView.js
>
>
applied, thanks! But reworked it to a more static declaration in and avoided
introducing the slightly weird, over-general `Configuration -> Options` tab,
I just added it to the existing `Authentication` one for now, fits there OK
enough and solving the Configuration/Administration weirdness needs more thought
and a major release, as I'd like to avoid reshuffling components in a stable one.
prev parent reply other threads:[~2021-05-25 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 14:42 [pbs-devel] " Dominik Csapak
2021-05-12 19:24 ` Thomas Lamprecht
2021-05-25 5:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae194062-50f3-0c34-87d9-ec5ed4296821@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox