From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] api: tape: don't allow overwriting of ids in changer/drive config
Date: Wed, 24 Apr 2024 21:40:46 +0200 [thread overview]
Message-ID: <ab68eef2-56e9-4d15-ac05-31b801debc01@proxmox.com> (raw)
In-Reply-To: <20240306093945.1463987-1-d.csapak@proxmox.com>
Am 06/03/2024 um 10:39 schrieb Dominik Csapak:
> by checking the whole section config for an existing id, not only the
> ones of the given type.
>
> This prevents creation of a drive config with the same name as an
> existing changer and vice versa, as it is confusing that existing things
> get deleted, and we can get in the situation that we reference a changer
> that does not exist anymore, i.e. consider this:
>
> * create a changer with name `foo`
> * create a drive with name `foo` and select changer `foo` for it
>
> this would delete the changer config, but still reference it, leading
> to errors when trying to use it.
>
> We could implement support for separate id namespaces in section configs
> for different types, but this is much more easier to do and be enough
> for now.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> If we decide to implement different id namespaces in the section config
> later, then this commit can be reverted.
>
> src/api2/config/changer.rs | 8 ++++----
> src/api2/config/drive.rs | 7 ++++---
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-04-24 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:39 [pbs-devel] " Dominik Csapak
2024-04-24 19:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab68eef2-56e9-4d15-ac05-31b801debc01@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox