[pbs-devel] [PATCH proxmox-backup v7] ui: fix #4260: add dynamic notes in backup group comment

[pbs-devel] [PATCH proxmox-backup v7] ui: fix #4260: add dynamic notes in backup group comment

[Philipp Hufnagl]

When there is no comment for a backup group, the comment of the last
snapshot in this group will be shown slightly grayed out as long as
the group is collapsed.

Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---

Changes since v1:
 * code quality improvements
 * remove unused variable


 www/css/ext6-pbs.css     |  4 ++++
 www/datastore/Content.js | 14 +++++++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 5fd65d25..95a655cf 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -227,6 +227,10 @@ span.snapshot-comment-column {
     width: calc(100% - 18px);
 }
 
+.pmx-faded {
+    opacity: 0.7;
+}
+
 .x-action-col-icon.good:before {
     color: #21BF4B;
 }
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 9fc07d49..6006201c 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -287,6 +287,7 @@ Ext.define('PBS.DataStoreContent', {
 		    if (item["backup-time"] > last_backup && item.size !== null) {
 			last_backup = item["backup-time"];
 			group["backup-time"] = last_backup;
+			group["last-comment"] = item.comment;
 			group.files = item.files;
 			group.size = item.size;
 			group.owner = item.owner;
@@ -903,13 +904,20 @@ Ext.define('PBS.DataStoreContent', {
 		if (!data || data.leaf || data.root) {
 		    return '';
 		}
-		if (v === undefined || v === null) {
-		    v = '';
+
+		let additionalClasses = "";
+		if (!v) {
+		    if (!data.expanded) {
+			v = data['last-comment'] ?? '';
+			additionalClasses = "pmx-faded";
+		    } else {
+			v = '';
+		    }
 		}
 		v = Ext.String.htmlEncode(v);
 		let icon = 'x-action-col-icon fa fa-fw fa-pencil pointer';
 
-		return `<span class="snapshot-comment-column">${v}</span>
+		return `<span class="snapshot-comment-column ${additionalClasses}">${v}</span>
 		    <i data-qtip="${gettext('Edit')}" style="float: right; margin: 0px;" class="${icon}"></i>`;
 	    },
 	    listeners: {
-- 
2.39.2

[pbs-devel] applied: [PATCH proxmox-backup v7] ui: fix #4260: add dynamic notes in backup group comment

[Thomas Lamprecht]

Am 13/10/2023 um 16:37 schrieb Philipp Hufnagl:
> When there is no comment for a backup group, the comment of the last
> snapshot in this group will be shown slightly grayed out as long as
> the group is collapsed.
> 
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
> 
> Changes since v1:
>  * code quality improvements
>  * remove unused variable
> 
> 
>  www/css/ext6-pbs.css     |  4 ++++
>  www/datastore/Content.js | 14 +++++++++++---
>  2 files changed, 15 insertions(+), 3 deletions(-)
> 
>

applied, thanks! 

But I renamed the utility class name to "pmx-opacity-75" in a follow-up,
(and as the name suggest set the value to three/quarters) as faded sounded
a bit weird to me and wasn't really telling, first I thought about using
"dimmed", then "dimmed-opacity", and finally I just figured to follow the
"Nomen est omen" saying and use a very telling name.