From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 2/2] ldap: only search base of base_dn when checking connection
Date: Tue, 25 Jul 2023 10:56:28 +0200 [thread overview]
Message-ID: <aa5cfb27-1ea0-57ac-fe9e-84f87b6f6960@proxmox.com> (raw)
In-Reply-To: <20230721143403.1288116-2-s.sterz@proxmox.com>
Looks good to me! (also applies to the new integration tests)
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
On 7/21/23 16:34, Stefan Sterz wrote:
> * when using an anonymous bind with slapd in its default configuration
> the default size limit will also be enforced against a paged
> search. this means that while a configuration may succeed with 5
> users with an anonymous bind, it will fail with 500+ users.
> * if the client specifies a size limit for the search and the server
> finds more results than specified by the search limit it will
> return only the specified amount of results. however, the result
> code will still be 4 (sizeLimitExceeded) resulting in an error. the
> same happens if the server specifies a limit and the search exceeds
> it. it also uses the the result code 4 (sizeLimitExceeded) in that
> case.
> * if a streaming_search is finished before all results are retrieved,
> ldap3 will handle this as specified in the relevant rfc from what i
> can tell [1]. however, the result code will then be 88 for a user
> canceled request, which is treated as an `Err` Result in ldap3.
>
> [1]: https://datatracker.ietf.org/doc/html/rfc2696
--
- Lukas
next prev parent reply other threads:[~2023-07-25 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 14:34 [pbs-devel] [PATCH proxmox 1/2] ldap: add an integration test for `check_connection` Stefan Sterz
2023-07-21 14:34 ` [pbs-devel] [PATCH proxmox 2/2] ldap: only search base of base_dn when checking connection Stefan Sterz
2023-07-25 8:56 ` Lukas Wagner [this message]
2023-08-08 12:03 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5cfb27-1ea0-57ac-fe9e-84f87b6f6960@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox