public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix refresh after TFA unlock
Date: Tue, 27 Jun 2023 13:29:23 +0200	[thread overview]
Message-ID: <aa1d24fb-a8d5-d753-0d7d-409b15b404e4@proxmox.com> (raw)
In-Reply-To: <20230627100452.328303-2-l.wagner@proxmox.com>

while it does work, the correct way to fix this is to add the column dataindex
to the model definition, since that is what the diffstore uses to update it's
data on a load

i sent a fix for that, which is intended to be applied instead of this patch:

https://lists.proxmox.com/pipermail/pbs-devel/2023-June/006244.html

On 6/27/23 12:04, Lukas Wagner wrote:
> Problem was that refresh after unlock did not work properly.
> Also calling load on the outer store seems to fix it, but I'm
> not sure why. Judging from the code in `DiffStore.js`, the
> outer store seems be subscribed to the `load` event from `rstore`,
> performing a load itself if the event occurs.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   www/config/UserView.js | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/www/config/UserView.js b/www/config/UserView.js
> index 9a0a0b2b..168af902 100644
> --- a/www/config/UserView.js
> +++ b/www/config/UserView.js
> @@ -95,7 +95,10 @@ Ext.define('PBS.config.UserView', {
>   	    return Ext.String.htmlEncode(userid.match(/^(.+)@([^@]+)$/)[2]);
>   	},
>   
> -	reload: function() { this.getView().getStore().rstore.load(); },
> +	reload: function() {
> +	    this.getView().getStore().rstore.load();
> +	    this.getView().getStore().load();
> +	},
>   
>   	init: function(view) {
>   	    Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);





  reply	other threads:[~2023-06-27 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 10:04 [pbs-devel] [PATCH proxmox-backup 1/2] ui: add missing unlockTfa handler Lukas Wagner
2023-06-27 10:04 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix refresh after TFA unlock Lukas Wagner
2023-06-27 11:29   ` Dominik Csapak [this message]
2023-06-27 11:30     ` Lukas Wagner
2023-06-27 11:28 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: add missing unlockTfa handler Dominik Csapak
2023-06-27 11:32 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa1d24fb-a8d5-d753-0d7d-409b15b404e4@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal