Re: [pbs-devel] [PATCH proxmox-backup v10 24/46] ui: add s3 client edit window for configuration create/edit

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 21.07.25 um 18:45 schrieb Christian Ebner:
> Adds an edit window for creating or editing S3 client configurations.
> Loosely based on the same edit window for the remote configuration.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 9:
> - no changes
> 
>  www/window/S3ClientEdit.js | 148 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 148 insertions(+)
>  create mode 100644 www/window/S3ClientEdit.js
> 
> diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
> new file mode 100644
> index 000000000..b22e920f8
> --- /dev/null
> +++ b/www/window/S3ClientEdit.js
> @@ -0,0 +1,148 @@

--8<-- snip -->8--

> +    getValues: function () {
> +        let me = this;
> +        let values = me.callParent(arguments);
> +
> +        if (me.isCreate) {
> +            /// Secrets are stored into separate config, but set the same id for both configs
> +            values['secrets-id'] = values.id;
> +        }

The whole if above can be now dropped, one will actually get an error otherwise
when creating a new S3 client on the web UI.

I can squash that in on applying if nothing else comes up.

> +
> +        if (values.delete && !Ext.isArray(values.delete)) {
> +            values.delete = values.delete.split(',');
> +        }
> +        PBS.Utils.delete_if_default(values, 'path-style', false, me.isCreate);
> +
> +        if (values['access-key'] === '') {
> +            delete values['access-key'];
> +        }
> +
> +        if (values['secret-key'] === '') {
> +            delete values['secret-key'];
> +        }
> +
> +        return values;
> +    },
> +});



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel