From: Christian Ebner <c.ebner@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] garbage collection: track chunk cache stats and show in task log
Date: Fri, 16 May 2025 12:29:27 +0200 [thread overview]
Message-ID: <a8dae229-2677-4e63-aab3-d550558a4b8a@proxmox.com> (raw)
In-Reply-To: <be14a6f0-b959-4837-9215-c0849c564bf8@proxmox.com>
On 5/16/25 11:54, Lukas Wagner wrote:
>
>
> On 2025-05-16 10:58, Christian Ebner wrote:
>> Count the chunk cache hits and misses and display the resulting
>> values in the garbage collection task log summary.
>>
>> This allows to investigate possible issues and tune cache capacity,
>> also by being able to compare to other values in the summary such
>> as the on disk chunk count.
>>
>> Exemplary output
>> ```
>> 2025-05-16T10:41:29+02:00: Chunk cache: hits 38118, misses 10017
>
> I think it would be nice to also print the hit ratio :) For the
> example here it should be 79%, if my math is correct.
Sure, can add that as well as it is indeed more straight forward and
intuitive!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-05-16 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 8:58 [pbs-devel] [PATCH proxmox proxmox-backup 0/2] add GC chunk cache stats Christian Ebner
2025-05-16 8:58 ` [pbs-devel] [PATCH proxmox 1/1] pbs api types: extend garbage collection status by " Christian Ebner
2025-05-16 8:58 ` [pbs-devel] [PATCH proxmox-backup 2/2] garbage collection: track chunk cache stats and show in task log Christian Ebner
2025-05-16 9:54 ` Lukas Wagner
2025-05-16 10:29 ` Christian Ebner [this message]
2025-05-19 5:56 ` [pbs-devel] superseded: [PATCH proxmox proxmox-backup 0/2] add GC chunk cache stats Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8dae229-2677-4e63-aab3-d550558a4b8a@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal