From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] ui: fix #4260: add dynamic notes in backup group comment
Date: Mon, 2 Oct 2023 13:55:09 +0200 [thread overview]
Message-ID: <a88d3787-0920-d785-315c-898a2ba1596e@proxmox.com> (raw)
In-Reply-To: <CVXWOMPGNF2E.2LKIERSI07P71@pali>
On 10/2/23 13:13, Lukas Wagner wrote:
> On Mon Oct 2, 2023 at 10:38 AM CEST, Philipp Hufnagl wrote:
>> - if (v === undefined || v === null) {
>> - v = '';
>> +
>> + let additional_classes = "";
>
> Note: I know the codebase is in some parts inconsistent in that regard, but
> for new code please use camelCase for variables and functions [1].
>
> [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide
>
> Apart from that, the changes look fine and work as advertised.
>
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>
>
Thank you for spotting! I made a v3
prev parent reply other threads:[~2023-10-02 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 8:38 Philipp Hufnagl
2023-10-02 11:13 ` Lukas Wagner
2023-10-02 11:55 ` Philipp Hufnagl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a88d3787-0920-d785-315c-898a2ba1596e@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox