From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] ui: add 'show connection information' button for datastores
Date: Wed, 29 Nov 2023 17:14:45 +0100 [thread overview]
Message-ID: <a7785c20-3e60-40fe-a3cd-e8b25217ef0a@proxmox.com> (raw)
In-Reply-To: <20231129154952.1708772-1-d.csapak@proxmox.com>
Am 29/11/2023 um 16:49 schrieb Dominik Csapak:
> this has a similar functionality as the 'show fingerprint' button,
> but for repository strings that are needed e.g. for the cli
>
> included with and without the current user for convenience
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * add help button
> * refactor the copy field (and remove the utils copy function)
> * put the button only in the datastore summary
> * style the copy buttons like toolbar buttons
> * add datastore and hostname also as copyable fields
> * seperate the cli/api fields with a title and (small) padding
> www/Makefile | 1 +
> www/Utils.js | 1 -
> www/datastore/Summary.js | 19 ++++-
> www/window/DatastoreRepoInfo.js | 126 ++++++++++++++++++++++++++++++++
> 4 files changed, 145 insertions(+), 2 deletions(-)
> create mode 100644 www/window/DatastoreRepoInfo.js
>
>
applied, thanks!
I squashed two small fixes into yours, namely the one for the icon color to
also work with light mode (adding the x-btn-icon-el-default-toolbar-small to
iconCls) and renaming the window title to "Connection Information" to fit the
adapted button text.
prev parent reply other threads:[~2023-11-29 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 15:49 [pbs-devel] " Dominik Csapak
2023-11-29 15:49 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] ui: add fingerprint also to the 'show connection information' window Dominik Csapak
2023-11-29 15:49 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] docs: note that the webui has a show connection information button Dominik Csapak
2023-11-29 16:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7785c20-3e60-40fe-a3cd-e8b25217ef0a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox