From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [RFC proxmox-backup 3/3] progress: shorter format
Date: Fri, 7 May 2021 12:15:18 +0200 [thread overview]
Message-ID: <a6f5c34c-225f-aa2c-e1f6-8cab708dc2b5@proxmox.com> (raw)
In-Reply-To: <20210507080310.2430082-3-f.gruenbichler@proxmox.com>
applied
On 5/7/21 10:03 AM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> separate patch since it changes format more fundamentally, but can be squashed
> with previous patch if applied.
>
> src/backup/store_progress.rs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/backup/store_progress.rs b/src/backup/store_progress.rs
> index e355c9bf..754727fc 100644
> --- a/src/backup/store_progress.rs
> +++ b/src/backup/store_progress.rs
> @@ -42,7 +42,7 @@ impl std::fmt::Display for StoreProgress {
> if self.group_snapshots == 0 {
> write!(
> f,
> - "{:.2}% ({} of {} groups)",
> + "{:.2}% ({}/{} groups)",
> self.percentage() * 100.0,
> self.done_groups,
> self.total_groups,
> @@ -50,7 +50,7 @@ impl std::fmt::Display for StoreProgress {
> } else if self.total_groups == 1 {
> write!(
> f,
> - "{:.2}% ({} of {} snapshots)",
> + "{:.2}% ({}/{} snapshots)",
> self.percentage() * 100.0,
> self.done_snapshots,
> self.group_snapshots,
> @@ -58,7 +58,7 @@ impl std::fmt::Display for StoreProgress {
> } else if self.done_snapshots == self.group_snapshots {
> write!(
> f,
> - "{:.2}% ({} of {} groups)",
> + "{:.2}% ({}/{} groups)",
> self.percentage() * 100.0,
> current_group,
> self.total_groups,
> @@ -66,7 +66,7 @@ impl std::fmt::Display for StoreProgress {
> } else {
> write!(
> f,
> - "{:.2}% ({} of {} groups, {} of {} group #{}'s snapshots)",
> + "{:.2}% ({}/{} groups, {}/{} snapshots in group #{})",
> self.percentage() * 100.0,
> self.done_groups,
> self.total_groups,
next prev parent reply other threads:[~2021-05-07 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 8:03 [pbs-devel] [PATCH proxmox-backup 1/3] fix #3331: improve progress for last snapshot in group Fabian Grünbichler
2021-05-07 8:03 ` [pbs-devel] [RFC proxmox-backup 2/3] progress: add current group to output Fabian Grünbichler
2021-05-07 10:15 ` [pbs-devel] applied: " Dietmar Maurer
2021-05-07 8:03 ` [pbs-devel] [RFC proxmox-backup 3/3] progress: shorter format Fabian Grünbichler
2021-05-07 10:15 ` Dietmar Maurer [this message]
2021-05-07 9:29 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] fix #3331: improve progress for last snapshot in group Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f5c34c-225f-aa2c-e1f6-8cab708dc2b5@proxmox.com \
--to=dietmar@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox