From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH] log: ignore to_stdout parameter
Date: Wed, 27 Nov 2024 13:33:53 +0100 [thread overview]
Message-ID: <a59408e5-c2de-42c0-91bc-d7deef27093b@proxmox.com> (raw)
In-Reply-To: <20241127114650.229625-1-g.goller@proxmox.com>
Am 27.11.24 um 12:46 schrieb Gabriel Goller:
> This parameter causes the FileLogger to duplicate the log output to
> stdout. This causes duplicate output on proxmox-backup-manager because
> this is now handled by tracing. This should be removed completely in the
> future.
> In the worst case this will only result in missing log lines on stdout
> (which is visible only on proxmox-backup-manager/client invocations
> anyway).
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> proxmox-log/src/file_logger.rs | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
>
applied, with a doc-comment added to the respective struct member so that it's
less likely that this will get new users, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-27 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:46 [pbs-devel] " Gabriel Goller
2024-11-27 12:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59408e5-c2de-42c0-91bc-d7deef27093b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox