From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-apt] depend on proxmox 0.12.0, bump version to 0.5.1-1
Date: Tue, 20 Jul 2021 19:25:10 +0200 [thread overview]
Message-ID: <a345c3f2-ceb2-f99c-a8a6-b1f4cb1c550a@proxmox.com> (raw)
In-Reply-To: <20210720115158.376164-1-dietmar@proxmox.com>
applied series, had to do a few fixups though:
* bump proxmox-api-macro and proxmox-http as they both use proxmox and are
already present in PBS 1.X based on Buster, so we need some version room for doing
stable updates there
* squashed in d/control updates in proxmox-apt in your commit
* fixed proxmox-backup's d/control, we do not use debcargo anymore there, so it needs to
be adapted manual for now (could and should be automated though)
* fixed the use in openid `src/api2/access/openid.rs` which was probably missed as it's
behind the "openid" cargo "cfg" flag and no full `make deb` or `cargo build --cfg openid`
was done. I squashed the change into your patch, IMO there was no need for a separate
fixup commit here.
One thing I do not really like is the name of the helper, as `open_backup_lockfile` sounds
like it would open the lockfile of a backup (snapshot), but that's not the case.
IMO the backup is irrelevant here, we just have a privileged and unprivileged user,
here it's `backup` in PVE `www-data`, the actual user does not matters much for the
code, and even if the name would still be confusing.
I'd use rather a name like `open_lockfile_unpriv`, but as this is all contained to that one
repo it can be changed at any time, so I applied it as is for now.
ps. the patches are lacking your `Signed-off-by`, no biggie currently, but we try to
add that nonetheless, thanks!
prev parent reply other threads:[~2021-07-20 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 11:51 [pbs-devel] " Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox-openid-rs] depend on proxmox 0.12.0, bump version to 0.6.1 Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox 1/4] new helper atomic_open_or_create_file() Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox-backup 1/2] use new atomic_open_or_create_file Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox-backup 2/2] add helpers to write configuration files Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox 2/4] open_file_locked: add options parameter (CreateOptions) Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox 3/4] bump proxmox version to 0.12.0-1 Dietmar Maurer
2021-07-20 11:51 ` [pbs-devel] [PATCH proxmox 4/4] update versions in generated control files Dietmar Maurer
2021-07-20 17:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a345c3f2-ceb2-f99c-a8a6-b1f4cb1c550a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox