public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs
Date: Tue, 12 Jan 2021 10:54:54 +0100	[thread overview]
Message-ID: <a309b9d6-407a-de28-c117-61233bcfac59@proxmox.com> (raw)
In-Reply-To: <20210112092117.22444-1-d.csapak@proxmox.com>

On 12.01.21 10:21, Dominik Csapak wrote:
> an empty schedule means 'none', so do not fill it with the default
> in case we edit an existing job (like we do already for sync jobs)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/window/VerifyJobEdit.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

this was already applied by Dietmar, just noting so that not another tries to
re-apply it ;)

FWIW, adding an explicit enable checkbox and making the schedule required when
that box is checked could be more user friendly - backend behaviour would not
need to change - just a thought.





      reply	other threads:[~2021-01-12  9:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  9:21 [pbs-devel] " Dominik Csapak
2021-01-12  9:54 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a309b9d6-407a-de28-c117-61233bcfac59@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal