From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Fiona Ebner" <f.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: prune job edit: fix disabling jobs
Date: Mon, 14 Nov 2022 15:01:33 +0100 [thread overview]
Message-ID: <a2bce5f2-8b1b-c409-407b-1c63dc82e41f@proxmox.com> (raw)
In-Reply-To: <1668432340.zxcajjjalx.astroid@yuna.none>
On 11/14/22 14:26, Fabian Grünbichler wrote:
> On November 14, 2022 11:54 am, Dominik Csapak wrote:
>> IMO good, but do we really drop unrecognized parameters in the api?
>> is that intentional? (iow. in pve it would have triggered an api exception
>> since that parameter does not exist)
>
> yes, if it's an AllOf Schema (which everything containing a flattened type is).
> for regular ObjectSchema-s, AdditionalProperties like in PVE is configurable.
>
meh... for configuration APIs i quite like the PVE behavior, since we can catch
such things much earlier.
next prev parent reply other threads:[~2022-11-14 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:42 Fiona Ebner
2022-11-14 10:54 ` Dominik Csapak
2022-11-14 13:26 ` Fabian Grünbichler
2022-11-14 14:01 ` Dominik Csapak [this message]
2022-11-15 14:29 ` Thomas Lamprecht
2022-11-16 9:41 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2bce5f2-8b1b-c409-407b-1c63dc82e41f@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox