From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] fix #4483: fix `task log` command interrupt handling
Date: Thu, 19 Jan 2023 10:12:39 +0100 [thread overview]
Message-ID: <a1fcc624-c01f-e662-f42c-67bb4e5d32ad@proxmox.com> (raw)
In-Reply-To: <20230118135342.1226289-1-f.gruenbichler@proxmox.com>
Am 18/01/2023 um 14:53 schrieb Fabian Grünbichler:
> `proxmox-backup-client task log ..` and `proxmox-backup-manager task log ..`
> are used to view the logs of tasks that have been started by another client, so
> interrupting the task progress view should not forward the interrupt to the
> running task. other call sites of the same helper(s) that spawn a task and then
> print its progress should keep the old behaviour of interrupting the spawned
> task on C^c.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> pbs-client/src/task_log.rs | 26 +++++++++++++++++---------
> proxmox-backup-client/src/task.rs | 2 +-
> src/bin/proxmox-backup-manager.rs | 2 +-
> 3 files changed, 19 insertions(+), 11 deletions(-)
>
> @@ -119,7 +127,7 @@ pub async fn view_task_result(
> let data = &result["data"];
> if output_format == "text" {
> if let Some(upid) = data.as_str() {
> - display_task_log(client, upid, true).await?;
> + display_task_log(client, upid, true, true).await?;
the calling signature starts to become a bit opaque (mapping multiple booleans or
other immediate values has some overhead - without fancy LSP that is ;-)
But for now still somewhat fine.. applied, thanks!
prev parent reply other threads:[~2023-01-19 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 13:53 [pbs-devel] " Fabian Grünbichler
2023-01-19 9:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1fcc624-c01f-e662-f42c-67bb4e5d32ad@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox