[pbs-devel] [PATCH proxmox stable-bookworm] network-api: only depend on proxmox-ve-config with 'impl' feature

[pbs-devel] [PATCH proxmox stable-bookworm] network-api: only depend on proxmox-ve-config with 'impl' feature

[Dominik Csapak]

we only use this crate in src/config/helper.rs, and the whole config
module is guarded by the 'impl' feature, so the dependency should only
be necessary there.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 proxmox-network-api/Cargo.toml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/proxmox-network-api/Cargo.toml b/proxmox-network-api/Cargo.toml
index 26e5bda9..0fd61a2c 100644
--- a/proxmox-network-api/Cargo.toml
+++ b/proxmox-network-api/Cargo.toml
@@ -25,7 +25,7 @@ proxmox-sys = { workspace = true, optional = true }
 proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] }
 proxmox-config-digest = { workspace = true, optional = true }
 proxmox-product-config = { workspace = true, optional = true }
-proxmox-ve-config = "0.2.3"
+proxmox-ve-config = { version = "0.2.3", optional = true }
 
 [features]
 default = []
@@ -36,4 +36,5 @@ impl = [
     "dep:nix",
     "dep:libc",
     "dep:proxmox-sys",
+    "dep:proxmox-ve-config",
 ]
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox stable-bookworm] network-api: only depend on proxmox-ve-config with 'impl' feature

[Stefan Hanreich]

successfully built proxmox-datacenter-manager again with this patch, so
consider this:

Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>

On 8/13/25 10:20 AM, Dominik Csapak wrote:
> we only use this crate in src/config/helper.rs, and the whole config
> module is guarded by the 'impl' feature, so the dependency should only
> be necessary there.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  proxmox-network-api/Cargo.toml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/proxmox-network-api/Cargo.toml b/proxmox-network-api/Cargo.toml
> index 26e5bda9..0fd61a2c 100644
> --- a/proxmox-network-api/Cargo.toml
> +++ b/proxmox-network-api/Cargo.toml
> @@ -25,7 +25,7 @@ proxmox-sys = { workspace = true, optional = true }
>  proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] }
>  proxmox-config-digest = { workspace = true, optional = true }
>  proxmox-product-config = { workspace = true, optional = true }
> -proxmox-ve-config = "0.2.3"
> +proxmox-ve-config = { version = "0.2.3", optional = true }
>  
>  [features]
>  default = []
> @@ -36,4 +36,5 @@ impl = [
>      "dep:nix",
>      "dep:libc",
>      "dep:proxmox-sys",
> +    "dep:proxmox-ve-config",
>  ]



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox stable-bookworm] network-api: only depend on proxmox-ve-config with 'impl' feature

[Fabian Grünbichler]

On Wed, 13 Aug 2025 10:20:39 +0200, Dominik Csapak wrote:
> we only use this crate in src/config/helper.rs, and the whole config
> module is guarded by the 'impl' feature, so the dependency should only
> be necessary there.
> 
> 

Applied, thanks!

[1/1] network-api: only depend on proxmox-ve-config with 'impl' feature
      (no commit info)

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel