From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox stable-bookworm] network-api: only depend on proxmox-ve-config with 'impl' feature
Date: Wed, 13 Aug 2025 10:45:41 +0200 [thread overview]
Message-ID: <a19e5b8f-e50c-4582-8600-1622251c74e6@proxmox.com> (raw)
In-Reply-To: <20250813082039.1123484-1-d.csapak@proxmox.com>
successfully built proxmox-datacenter-manager again with this patch, so
consider this:
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
On 8/13/25 10:20 AM, Dominik Csapak wrote:
> we only use this crate in src/config/helper.rs, and the whole config
> module is guarded by the 'impl' feature, so the dependency should only
> be necessary there.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> proxmox-network-api/Cargo.toml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/proxmox-network-api/Cargo.toml b/proxmox-network-api/Cargo.toml
> index 26e5bda9..0fd61a2c 100644
> --- a/proxmox-network-api/Cargo.toml
> +++ b/proxmox-network-api/Cargo.toml
> @@ -25,7 +25,7 @@ proxmox-sys = { workspace = true, optional = true }
> proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] }
> proxmox-config-digest = { workspace = true, optional = true }
> proxmox-product-config = { workspace = true, optional = true }
> -proxmox-ve-config = "0.2.3"
> +proxmox-ve-config = { version = "0.2.3", optional = true }
>
> [features]
> default = []
> @@ -36,4 +36,5 @@ impl = [
> "dep:nix",
> "dep:libc",
> "dep:proxmox-sys",
> + "dep:proxmox-ve-config",
> ]
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-13 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 8:20 Dominik Csapak
2025-08-13 8:45 ` Stefan Hanreich [this message]
2025-08-13 9:29 ` [pbs-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19e5b8f-e50c-4582-8600-1622251c74e6@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox