Re: [PATCH proxmox v4 02/30] pbs-api-types: sync job: add optional cryptographic keys to config

[Christian Ebner <c.ebner@proxmox.com>]

On 4/22/26 5:17 PM, Michael Köppl wrote:
> On Mon Apr 20, 2026 at 6:15 PM CEST, Christian Ebner wrote:
> 
> [snip]
> 
>>   const_regex! {
>> @@ -664,6 +665,18 @@ pub const UNMOUNT_ON_SYNC_DONE_SCHEMA: Schema =
>>               type: SyncDirection,
>>               optional: true,
>>           },
>> +        "active-encryption-key": {
>> +            schema: CRYPT_KEY_ID_SCHEMA,
>> +            optional: true,
>> +        },
>> +        "associated-key": {
> 
> nit: this should probably be "associated-keys"

this is not a typo but rather on purpose, please see the commit message 
for the reason why this was chosen as is.

> 
>> +            type: Array,
>> +            description: "List of cryptographic keys associated with sync job.",
>> +            items: {
>> +                schema: CRYPT_KEY_ID_SCHEMA,
>> +            },
>> +            optional: true,
>> +        },
>>       }
>>   )]
>>   #[derive(Serialize, Deserialize, Clone, Updater, PartialEq)]
>> @@ -709,6 +722,10 @@ pub struct SyncJobConfig {
>>       pub unmount_on_done: Option<bool>,
>>       #[serde(skip_serializing_if = "Option::is_none")]
>>       pub sync_direction: Option<SyncDirection>,
>> +    #[serde(skip_serializing_if = "Option::is_none")]
>> +    pub active_encryption_key: Option<String>,
>> +    #[serde(skip_serializing_if = "Option::is_none")]
>> +    pub associated_key: Option<Vec<String>>,
> 
> nit: same here
> 
>>   }
>>   
>>   impl SyncJobConfig {
>