Re: [pbs-devel] [PATCH proxmox-backup v2 2/3] ui: Show if Filter includes or excludes

[Lukas Wagner <l.wagner@proxmox.com>]

On 11/9/23 15:43, Philipp Hufnagl wrote:
> To make the UI compatible, the Group Filter dialogue has been extended
> by a second list, so it now features a list for all include filter and
> one for all exclude filters.
> 
> Internally, all include as well as exclude filter are managed into one
> list. The 2 list view is just for a cleaner representation in the UI.
> 

The edit window becomes pretty tall with the second grid for the 
excludes. Assuming a screen resolution of 1368x768 (which is still in 
use in some low-end laptops) and subtracting a few pixels for task/menu 
bars, the edit window is not really usable on a screen with that 
resolution. You can test/simulate that by pressing Ctrl-Shift-M in 
Firefox while being in web inspector view.

Maybe we could have the exludes in the same grid view, but sort it so 
that the 'includes' come before 'exludes'? Alternatively, we could 
reduce the height of the two grid views (not sure how many rules people 
have on average, it'd be bad if people have to scroll a lot)


-- 
- Lukas