From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v6 1/2] fix #5439: allow to reuse existing datastore
Date: Mon, 11 Nov 2024 23:56:08 +0100 [thread overview]
Message-ID: <a0646ab5-9ed4-4e17-b39b-58f1937ada06@proxmox.com> (raw)
In-Reply-To: <20240829125844.290208-1-g.goller@proxmox.com>
Am 29.08.24 um 14:58 schrieb Gabriel Goller:
> Disallow creating datastores in non-empty directories. Allow adding
> existing datastores via a 'reuse-datastore' checkmark. This only checks
> if all the necessary directories (.chunks + subdirectories and .lock)
> exist and have the correct permissions. Note that the reuse-datastore
> path does not open the datastore, so that we don't drop the
> ProcessLocker of an existing datastore.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> v6, thanks @Wolfgang
> - iterate over directories with loop
> - make `chunk_dir_accessible` not pub
> - remove unnecessary clone
>
> v5, thanks @Wolfgang:
> - remove unnecessary call to `chunk_dir_accessible`
> - match on exact permissions
> - remove unused worker reference
>
> v4, thanks @Thomas:
> - move reuse-datastore checkbox to "advanced options"
>
> v3, thanks @Fabian:
> - don't open chunkstore on existing datastore, as this drops the
> previous ProcessLocker
> - factor out `ChunkStore::open` checks and call them in reuse-datastore
> path as well
>
> v2, thanks @Fabian:
> - also check on frontend for root
> - forbid datastore creation if dir not empty
> - add reuse-datastore option
> - verify chunkstore directories permissions and owners
>
> pbs-datastore/src/chunk_store.rs | 73 ++++++++++++++++++++++++++++----
> src/api2/config/datastore.rs | 45 +++++++++++++++-----
> src/api2/node/disks/directory.rs | 4 +-
> src/api2/node/disks/zfs.rs | 4 +-
> 4 files changed, 105 insertions(+), 21 deletions(-)
>
>
applied series, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-11 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 12:58 [pbs-devel] " Gabriel Goller
2024-08-29 12:58 ` [pbs-devel] [PATCH proxmox-backup v6 2/2] web: disallow datastore in root, add reuse-datastore flag Gabriel Goller
2024-11-11 22:56 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0646ab5-9ed4-4e17-b39b-58f1937ada06@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox