Re: [PATCH proxmox-widget-toolkit v2 19/34] notifications: matcher: add support for match expressions

["Michael Köppl" <m.koeppl@proxmox.com>]

On Thu Oct 1, 2026 at 10:36 AM CEST, Lukas Wagner wrote:

[snip]

> +                        case 'one-of':
> +                            {
> +                                let children = [];
> +                                for (let child of value) {
> +                                    children.push(visit(child));
> +                                }
> +                                ret = {
> +                                    type: key,
> +                                    data: {},
> +                                    children,
> +                                    leaf: false,
> +                                };
> +                            }
> +                            break;
> +                        case 'not':
> +                            {
> +                                let child = visit(value);
> +                                ret = {
> +                                    ...child,
> +                                    invert: true,

Shouldn't this be `invert: !child.invert`? Because right now, this will
remove any negations already in an expression. If I add an expression
as follows:

	pvesh create /cluster/notifications/matchers \
		--name double-not \
		--target mail-to-root \
		--disable 1
		--expression '{"not":{"not":{"match":{"type":"severity","severities":["info"]}}}}'

the PVE UI displays this as "Severity: all except info". When I then
edit e.g. the comment and save it, the expression does not match what I
originally created anymore. The result is then:

pvesh get /cluster/notifications/matchers/test-double-not --output-format json-pretty
{
   "comment" : "test",
   "digest" : "1d9913fd302f057e7749d88bad0dd3c8f567e5e6315e2e1e885d532102c693ab",
   "disable" : 1,
   "expression" : "{\"not\":{\"match\":{\"type\":\"severity\",\"severities\":[\"info\"]}}}",
   "name" : "test-double-not",
   "origin" : "user-created",
   "target" : [
      "mail-to-root"
   ]
}

Similarly, `{"not":{"constant":false}}` becomes `{"constant":false}`.

> +                                };
> +                            }
> +                            break;
> +                        case 'constant': {
> +                            ret = {
> +                                type: 'match-always',
> +                                data: {},
> +                                invert: !value,
> +                                leaf: true,
> +                            };
> +                        }
> +                    }
> +
> +                    let iconCls = me.getNodeIcon(
> +                        ret.type,
> +                        ret.data,
> +                        ret.invert,
> +                        !!ret.children?.length,
> +                    );
> +
> +                    ret.iconCls = iconCls;
> +                    if (!ret.leaf) {
> +                        ret.expanded = true;

[snip]