Re: [PATCH proxmox 10/29] notify: matcher: add InlineCalendarMatcher

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Jul 24, 2026 at 8:47 AM CEST, Arthur Bied-Charreton wrote:
>> +impl fmt::Display for DailyDurationWrapper {
>> +    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
>> +        f.write_str(self.as_str())
>> +    }
>> +}
>> +
>> +impl FromStr for DailyDurationWrapper {
>> +    type Err = Error;
>> +
>> +    fn from_str(s: &str) -> Result<Self, Error> {
>> +        let daily_duration = proxmox_time::parse_daily_duration(s)
> we might wanna trim s here? this fails if s has a leading whitespace,
> which is a code path reachable via the UI (see [0]), and even if/when 
> that is fixed, i feel like it would be nicer to not fail to parse 
> because of surrounding whitespace (could also be done at another level
> of the call stack), since that would still be reachable via pvesh etc.
>
> [0] https://lore.proxmox.com/pve-devel/20260709115716.299836-1-l.wagner@proxmox.com/T/#mad9286504ecf2264333be5abe8b9e1f4966aeaeb

I think it's okay to be strict about the format at the API level, but of
course we should ensure that it's not possible to run into this
situation when editing the schedule via the UI.

I managed to reproduce the issue you reported, will try to fix it for
v2.