From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Christian Ebner" <c.ebner@proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>,
"Erik Fastermann" <e.fastermann@proxmox.com>,
<pbs-devel@lists.proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox v3 1/5] system-report: add crate for shared report generation
Date: Thu, 20 Aug 2026 15:46:17 +0200 [thread overview]
Message-ID: <DKTTFERN0JG8.6KFKCCFTC05P@proxmox.com> (raw)
In-Reply-To: <3bdff658-0aad-445a-bf4b-647a5e49371b@proxmox.com>
On Thu Aug 20, 2026 at 3:36 PM CEST, Christian Ebner wrote:
> On 8/20/26 3:31 PM, Lukas Wagner wrote:
>> Hi Erik,
>>
>> thanks a lot for tackling this!
>>
>> On Tue Aug 11, 2026 at 1:43 PM CEST, Erik Fastermann wrote:
>>> Factor the shared report generation from PBS and PDM into a new
>>> proxmox-system-report crate, so both generate their reports from a
>>> single implementation.
>>>
>>> The crate defines the common section order (FILES, COMMANDS,
>>> FUNCTIONS) and the set of general commands run on every product;
>>> products pass their own additional files, commands and functions on
>>> top. It produces no report on its own, so the user-visible changes
>>> land in the respective server packages.
>>>
>>> Suggested-by: Lukas Wagner <l.wagner@proxmox.com>
>>> Suggested-by: Christian Ebner <c.ebner@proxmox.com>
>>> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
>>> Tested-by: Christian Ebner <c.ebner@proxmox.com>
>>> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
>>> ---
>>> Cargo.toml | 2 +
>>> proxmox-system-report/Cargo.toml | 16 ++
>>> proxmox-system-report/debian/control | 36 ++++
>>> proxmox-system-report/debian/copyright | 18 ++
>>> proxmox-system-report/debian/debcargo.toml | 7 +
>>> proxmox-system-report/src/lib.rs | 239 +++++++++++++++++++++
>>> 6 files changed, 318 insertions(+)
>>> create mode 100644 proxmox-system-report/Cargo.toml
>>> create mode 100644 proxmox-system-report/debian/control
>>> create mode 100644 proxmox-system-report/debian/copyright
>>> create mode 100644 proxmox-system-report/debian/debcargo.toml
>>
>> This is missing a debian/changelog file, without it
>> `make proxmox-sytem-report-deb` does not work.
>>
>
> That's on me: I suggested to leave it out for the maintainer to set, as
> it will be outdated anyways, see
> https://lore.proxmox.com/pbs-devel/4d0f692b-29a9-4951-830e-efe145f7bbdd@proxmox.com/
>
> [..]
Ah, sorry, I did not see the former email chain.
I'm not a packaging pro, but could it make sense to set it to UNRELEASED
at first, and then the maintainer can use `dch -r` to release, which
should also update the timestamp (see `man dch` for reference).
so, as s full example:
rust-proxmox-system-report (1.0.0-1) UNRELEASED; urgency=medium
* initial version.
-- Proxmox Support Team <support@proxmox.com> Sun, 30 Nov 2025 16:52:02 +0100
Obviously, this is for proxmox.git maintainers to decide.
next prev parent reply other threads:[~2026-08-20 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 11:43 [PATCH proxmox{,-backup,-datacenter-manager} v3 0/5] factor system report into shared crate Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox v3 1/5] system-report: add crate for shared report generation Erik Fastermann
2026-08-20 13:32 ` Lukas Wagner
2026-08-20 13:36 ` Christian Ebner
2026-08-20 13:46 ` Lukas Wagner [this message]
2026-08-11 11:43 ` [PATCH proxmox-backup v3 2/5] d/control: depend on tools used by the system report Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-backup v3 3/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-datacenter-manager v3 4/5] d/control: depend on tools used by the system report Erik Fastermann
2026-08-20 12:53 ` applied: " Lukas Wagner
2026-08-11 11:43 ` [PATCH proxmox-datacenter-manager v3 5/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-08-12 9:59 ` [PATCH proxmox{,-backup,-datacenter-manager} v3 0/5] factor system report into shared crate Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKTTFERN0JG8.6KFKCCFTC05P@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox