Re: [PATCH proxmox{-backup,} v2 0/3] partially fix #6933: add option to specify zfs recordsize

["Nicolas Frey" <n.frey@proxmox.com>]

On Wed Aug 12, 2026 at 1:03 PM CEST, Shan Shaji wrote:
> The option to specify the `recordsize` was previously available neither
> in the UI nor in the CLI. Users had to configure it manually using the
> ZFS CLI. This series adds an option for specifying the `recordsize`
> through both the UI and `proxmox-backup-manager` when creating storage.
>
> Since adding support for editing this property at the dataset level
> would require more changes, I am sending the creation related
> changes first. Support for editing the property will be send
> as a separate series.
>
> changes since v1: Thanks @Nicolas Frey
>
> * Patch [3/3] - Add validation function identical to the one in Javscript to
>   verify if the passed recordsize is valid. If it's not valid, then the
>   backup manager exits without creating the pool. Earlier, even though
>   the recordsize format was wrong, the backup manager allowed executing
>   the zpool and zfs commands, which in turn created the pool with the
>   default(128k) recordsize, but the `zfs set` command failed with an error.

thanks for sending a v2! one small style nit on patch [3/3]. consider this:

Reviewed-by: Nicolas Frey <n.frey@proxmox.com>
Tested-by: Nicolas Frey <n.frey@proxmox.com>

>
> References:
> - https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Workload%20Tuning.html#dataset-recordsize
>
> proxmox-backup:
>
> Shan Shaji (2):
>   partially fix #6933: ui: storage: add option to specify zfs recordsize
>   partially fix #6933: bin: add option to specify ZFS recordsize
>
>  src/api2/node/disks/zfs.rs             | 14 +++++++++++--
>  src/bin/proxmox_backup_manager/disk.rs |  8 ++++++--
>  www/Utils.js                           | 28 ++++++++++++++++++++++++++
>  www/window/ZFSCreate.js                |  8 ++++++++
>  4 files changed, 54 insertions(+), 4 deletions(-)
>
>
> proxmox:
>
> Shan Shaji (1):
>   pbs-api-types: zfs: define schema for recordsize
>
>  pbs-api-types/src/zfs.rs | 68 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 68 insertions(+)
>
>
> Summary over all repositories:
>   5 files changed, 122 insertions(+), 4 deletions(-)