Re: [PATCH proxmox-backup 6/7] acme: fix #6372 implement ARI renewal information fetching.

["Shan Shaji" <s.shaji@proxmox.com>]

On Wed Jul 29, 2026 at 11:07 AM CEST, Manuel Federanko wrote:

[snip]

>>> diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_backup_manager/acme.rs
>>> index ed9e5868c..ea14cfe2b 100644
>>> --- a/src/bin/proxmox_backup_manager/acme.rs
>>> +++ b/src/bin/proxmox_backup_manager/acme.rs
>>> @@ -413,14 +413,6 @@ pub fn plugin_cli() -> CommandLineInterface {
>>>  )]
>>>  /// Order a new ACME certificate.
>>>  async fn order_acme_cert(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
>>> -    if !param["force"].as_bool().unwrap_or(false) {
>>> -        let (expires_soon, lead_days) = api2::node::certificates::check_renewal_needed()?;
>>> -        if !expires_soon {
>>> -            println!("Certificate does not expire within the next {lead_days} days, not renewing.");
>>> -            return Ok(());
>>> -        }
>>> -    }
>>> -
>> 
>> Hi, Since this was now removed, we no longer get console feedback If the
>> certificate doesn't expire soon. However, the status was visible inside the
>> task log. Would showing it in the console as well be a good UX?
> Agreed, I'd prefer that too, I'm unsure on how to achieve this

I have checked this one and AFAIU, this is because of our logger
intialization, where logs are written to the stderr only if no workertask
context exists or the event level is error. When I created the logger with the
plain_stderr_layer, i.e without the NoWorkerTask filter the log was
visible in the console.

I don't think that would be a good idea because now all the logs
inside the workertask context will be written to stderr. Alternatively, without
changing the filters, replacing the info! call for the “Certificate does not expire...”
message with println! would write it to stdout However, in that case, the
message would no longer be written to the task log.

> acme check is imo better handled in the worker.

Agreed, However without moving the check earlier, I am not
sure what is the best way to handle this. Perhaps others have a better
suggestion here. :)

>> 
>>>      let info = &api2::node::certificates::API_METHOD_RENEW_ACME_CERT;
>>>      let result = match info.handler {
>>>          ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>>> --
>>> 2.47.3
>>