Re: [PATCH] fix #7337: Keep track of deep link on OpenID login

["Shannon Sterz" <s.sterz@proxmox.com>]

On Thu Mar 12, 2026 at 3:30 PM CET, Arthur Bied-Charreton wrote:
> Previously, when opening a deep link without being logged into PBS, the
> hash was getting lost, redirecting the user to #pbsDashboard instead of
> /#<deeplink>.
>
> Store `window.location.hash` in sessionStorage (per-tab storage) before
> redirecting to the login URL, and add it to the history after successful
> login to direct the user to the deeplink they opened.
>
> `#pbsDashboard` remains the default redirect if no deeplink is stored.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  www/LoginView.js | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/www/LoginView.js b/www/LoginView.js
> index fd9594f6..b72e4223 100644
> --- a/www/LoginView.js
> +++ b/www/LoginView.js
> @@ -48,6 +48,7 @@ Ext.define('PBS.LoginView', {
>
>              if (this.getViewModel().data.openid === true) {
>                  const redirectURL = location.origin;
> +                sessionStorage.setItem('openid-deeplink', location.hash);

nit: i think it would be nicer if this was prefixed, so something like
"pbs-openid-deeplink". also quickly grep-ing over the widget toolkit and
pbs ui directory, it seems that for local storage we tend to prefer
camel case, though that isn't consistent.

>                  try {
>                      let resp = await Proxmox.Async.api2({
>                          url: '/api2/extjs/access/openid/auth-url',
> @@ -217,7 +218,13 @@ Ext.define('PBS.LoginView', {
>                                  let creds = response.result.data;
>                                  PBS.Utils.updateLoginData(creds);
>                                  PBS.app.changeView('mainview');
> -                                history.replaceState(null, '', `${redirectURL}#pbsDashboard`);
> +                                let deeplink = sessionStorage.getItem('openid-deeplink');
> +                                if (deeplink) {
> +                                    sessionStorage.removeItem('openid-deeplink');
> +                                    history.replaceState(null, '', `${redirectURL}${deeplink}`);
> +                                } else {
> +                                    history.replaceState(null, '', `${redirectURL}#pbsDashboard`);
> +                                }
>                              },
>                          });
>                      }

other than the small nit above, this looks good to me so consider this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>