From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #6398: api: allow non-pam users to access shell
Date: Tue, 07 Oct 2025 17:13:50 +0200 [thread overview]
Message-ID: <DDC6RR7K0TN8.1Y50I0E4R0MYZ@proxmox.com> (raw)
In-Reply-To: <acc32f15-5e57-40f6-a212-6d1e5a4b940e@proxmox.com>
Thanks @Thomas for the review, makes sense. I will create a v2 with
an updated commit message.
On Tue Oct 7, 2025 at 4:30 PM CEST, Thomas Lamprecht wrote:
> Am 15.09.25 um 14:58 schrieb Shan Shaji:
>> Right now PBS is not allowing users to access the shell if the user
>> is not a pam user even though the `Sys.Console` permission is
>> already given. To fix the issue removed the palm realm check.
>
> This is a explicit and dedicated check, it might not be warranted,
> but it might as well exist for a reason, so removing such explicit
> limitations really need to argue about that in the commit message.
>
> Here it would be probably enough to write that this is safe to do as
> all users that are not root@pam will get a login shell anyway, so
> they need to have some (PAM) login credentials available. This makes
> sense to have as e.g. a host could be use a central authentication
> system like LDAP/AD or OIDC as PBS realm and as PAM plugin. Or just
> favor using a non-pam user by default for PBS but still provide
> credentials to a administrative PAM user to their admins.
>
> Another argument to make is referencing pve-manager's commit
> 7914f5e7b ("node console: allow usage for non-pam realms"), which
> already implemented exactly this change for PVE (albeit also not
> with spelling out actual arguments for doing so)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-10-07 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 12:57 Shan Shaji
2025-10-07 11:51 ` Shan Shaji
2025-10-07 14:30 ` Thomas Lamprecht
2025-10-07 15:13 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDC6RR7K0TN8.1Y50I0E4R0MYZ@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox