From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Cc: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/3] pbs3to4: rework bootloader checks
Date: Thu, 21 Aug 2025 16:50:29 +0200 [thread overview]
Message-ID: <DC86U9TOZ8HB.31H3VTTJ3X8P@proxmox.com> (raw)
In-Reply-To: <20250821141719.4130062-1-s.ivanov@proxmox.com>
On Thu Aug 21, 2025 at 4:17 PM CEST, Stoiko Ivanov wrote:
> v1->v2:
> Shannon caught a logic-error (wrong negation) in the check if systemd-boot
> is actually used, and a useless temporary variable. additionally patch 2/3
> needed a rustfmt - huge thx!
>
> supersedes:
> https://lore.proxmox.com/pbs-devel/20250818194026.840749-1-s.ivanov@proxmox.com/T/#t
>
> Stoiko Ivanov (3):
> pbs3to4: fix logic error and typo in log message
> pbs3to4: use boolean variable for systemd-boot installation state
> pbs3to4: bootloader: only allow systemd-boot before upgrade when used
>
> src/bin/pbs3to4.rs | 61 ++++++++++++++++++++++++----------------------
> 1 file changed, 32 insertions(+), 29 deletions(-)
looks good to me, tested this series on the following set ups:
- legacy-mode boot -> outputs `SKIP: System booted in legacy-mode - no
need for additional packages`
- proxmox-boot-tool + grub but without secure boot -> outputs `FAIL:
systemd-boot meta-package installed. This will cause problems [..]`
- zfs + systemd-boot (no secure boot, but uefi) -> outputs `SKIP: not
yet upgraded, systemd-boot still needed for bootctl`
so consider this:
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-21 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:17 Stoiko Ivanov
2025-08-21 14:17 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] pbs3to4: fix logic error and typo in log message Stoiko Ivanov
2025-08-21 14:17 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] pbs3to4: use boolean variable for systemd-boot installation state Stoiko Ivanov
2025-08-21 14:17 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] pbs3to4: bootloader: only allow systemd-boot before upgrade when used Stoiko Ivanov
2025-08-21 14:50 ` Shannon Sterz [this message]
2025-08-22 13:41 ` [pbs-devel] applied: [PATCH proxmox-backup v2 0/3] pbs3to4: rework bootloader checks Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC86U9TOZ8HB.31H3VTTJ3X8P@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel-bounces@lists.proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox