From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow
Date: Wed, 06 Aug 2025 12:20:37 +0200 [thread overview]
Message-ID: <DBV9PH36D72U.26OD14RW1XTLG@proxmox.com> (raw)
In-Reply-To: <175447496640.32268.16650071049145923260.b4-ty@proxmox.com>
On Wed Aug 6, 2025 at 12:09 PM CEST, Thomas Lamprecht wrote:
> On Wed, 06 Aug 2025 11:57:02 +0200, Shannon Sterz wrote:
>> this was missed previously leading to the tfa part of the auth flow
>> not opting into the new auth flow. this meant the server did not add a
>> Set-Cookie header. after that whether or not a login worked fine
>> became a race between the refresh logic (which was opted into the new
>> flow and, thus, would yield a proper HttpOnly cookie) and other
>> requests.
>>
>> [...]
>
> Applied, thanks!
>
> tiny nit: we would prefer camelCase in JS, but that's just internal so we can
> change it at any time with a fallback to the previous property.
yes sorry, noticed that after i send it, just send a follow-up. snake
case is too much of a habbit at this point ^^'
> [1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow
> commit: 4e7c0d6a264557e4e9eea3b0cae2a97260848469
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-06 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 9:57 [pbs-devel] [PATCH proxmox-backup/widget-toolkit 0/2] opt PBS into the new HttpOnly flow for TFA challenges Shannon Sterz
2025-08-06 9:57 ` [pbs-devel] [PATCH widget-toolkit 1/1] tfa window: allow opting into the new http only flow for tfa challenges Shannon Sterz
2025-08-06 10:04 ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-06 9:57 ` [pbs-devel] [PATCH proxmox-backup 1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow Shannon Sterz
2025-08-06 10:09 ` Thomas Lamprecht
2025-08-06 10:20 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBV9PH36D72U.26OD14RW1XTLG@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox