From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Christian Ebner" <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] datastore: destroy: delete s3 in-use marker unconditionally
Date: Thu, 31 Jul 2025 13:26:22 +0200 [thread overview]
Message-ID: <DBQ7CJRB8B8V.1X4YO1B9MMOMX@proxmox.com> (raw)
In-Reply-To: <20250730152303.729778-1-c.ebner@proxmox.com>
On Wed Jul 30, 2025 at 5:23 PM CEST, Christian Ebner wrote:
> Currently, the in-use marker object for datastores backed by s3
> backend is only removed together with the data when all data is
> requested to be removed.
>
> It the data should be preserved, the in-use marker should however
> also be removed, allowing to reuse the datastore on the same or
> a different host without force overwriting the marker.
>
> Therefore, unconditionally clear the in-use marker from the S3
> object store. In order to use the predefined marker filename
> constant move it so it can be used during destruction as well.
>
> Suggested-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
[...]
Looks good to me. Quickly tested this by removing a datastore (without
ticking 'remove data') and then reimporting without ticking 'overwrite
in-use marker'. Also verified via the `mc` tool that the `.in-use`
marker is removed from the bucket, with the `.chunks` and `.cnt` dirs
still being in place as expecteded.
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-07-31 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 15:23 Christian Ebner
2025-07-31 10:18 ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-31 11:26 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBQ7CJRB8B8V.1X4YO1B9MMOMX@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox